Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vertex validation plots #4850

Merged
merged 5 commits into from Aug 1, 2014

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Jul 31, 2014

Fix computation of duplicate rate plots for GEN quantities.
Improve axis limits for few histograms.
Fix merge plots vs dz to use info from GEN.
Properly reset internal containers between different Input collections.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_2_X.

Improve vertex validation plots

It involves the following packages:

Validation/RecoVertex

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@cerati, @venturia, @GiacomoSguazzoni, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2014

Pull request #4850 was updated. @danduggan, @ojeda, @rovere, @deguio can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2014

@deguio
Copy link
Contributor

deguio commented Aug 1, 2014

+1
you forgot to mention that you are adding 66 new histograms.. ;)
ciao,
F.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

smuzaffar added a commit that referenced this pull request Aug 1, 2014
@smuzaffar smuzaffar merged commit 1f1ac3c into cms-sw:CMSSW_7_2_X Aug 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants