Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test configuration for reco+dqm+validation in unscheduled mode #4889

Merged
merged 7 commits into from Aug 11, 2014

Conversation

davidlange6
Copy link
Contributor

Changes needed to make reco+dqm+validation (step3) in MC run in unscheduled mode
runTheMatrix.py -w unsch -l 10025

Some changes to DQM/validation python were needed in order to avoid running producers on both a path and end path, which we should a) not need to do, and b) need to avoid for unscheduled mode

I also started to add the cmsDriver changes that are needed for running reco+miniaod together. There are problems with module conflicts between these things that need to be fixed before its working.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2014

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_2_X.

Test configuration for reco+dqm+validation in unscheduled mode

It involves the following packages:

Configuration/Applications
Configuration/PyReleaseValidation
DQMOffline/RecoB
FWCore/ParameterSet
Validation/RecoTrack

@Dr15Jones, @vlimant, @danduggan, @rovere, @cmsbuild, @franzoni, @nclopezo, @deguio, @Degano, @ojeda, @ktf, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @wmtan, @acaudron, @GiacomoSguazzoni, @wddgit, @VinInn, @rovere, @wmtford, @ferencek, @cerati, @pvmulder, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@franzoni
Copy link

franzoni commented Aug 6, 2014

Hello David,
If the target is having CMSSW overall run unscheduled by 72x (do I understand right?), we'll want to migrate the whole relval set to it (with a dedicated campaign of validation at the transition time), and we don't want to have a duplicate/separate set.
If for the next few pre-releases we want to have a separate batch (relval_unsch.py) of relvals dedicated to running unscheduled => fine by me.
Including the two dedicated test workflows directly in relval_standard.py would avoid having to remove a file in a few weeks time - not a showstopper, in any case.
cheers,
Giovanni

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2014

-1

Tested at: 8fcc908
I ran the usual tests and I found errors in the following unit tests:

---> test TestFWCoreParameterSetDriver had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4889/561/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2014

@ktf
Copy link
Contributor

ktf commented Aug 11, 2014

+1

@davidlange6
Copy link
Contributor Author

hum, thats strange. Its only python. The must be the change to Config.py that does this

On Aug 7, 2014, at 6:16 PM, Vincenzo Innocente notifications@github.com wrote:

It seems that merging with this PR forces in the whole CMSSW.
I think I will wait till it is integrated to try it out


Reply to this email directly or view it on GitHub.

@davidlange6
Copy link
Contributor Author

by-passing dqm sig. (as we in any case have a discussion scheduled about the validation sequence being an end path which is the reason for the changes affecting dqm here)

davidlange6 added a commit that referenced this pull request Aug 11, 2014
Test configuration for reco+dqm+validation in unscheduled mode
@davidlange6 davidlange6 merged commit 0cb6b89 into cms-sw:CMSSW_7_2_X Aug 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants