Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7x improvements in Fireworks reco geometry tag info #4915

Merged
merged 13 commits into from Aug 26, 2014

Conversation

alja
Copy link
Contributor

@alja alja commented Aug 9, 2014

Fireworks/Geometry:

  • write extra detectors (e.g. GEM or RE4) while writing idToGeo map and save it in TObjArray
  • a new pass of dumRecoGeomtery script -- improve options and documentation

Fireworks/Core:

  • check TObjArray for extra detectors
  • draw GEM optionally

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2014

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_1_X.

7x improvements in Fireworks reco geometry tag info

It involves the following packages:

Fireworks/Core
Fireworks/Geometry

@Dr15Jones, @cmsbuild, @alja, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@alja
Copy link
Contributor Author

alja commented Aug 9, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

Pull request #4915 was updated. @Dr15Jones, @cmsbuild, @alja, @nclopezo, @Degano, @ktf can you please check and sign again.

@cmsbuild
Copy link
Contributor

@alja
Copy link
Contributor Author

alja commented Aug 14, 2014

This change is related to cms-data/Fireworks-Geometry#4.

@alja
Copy link
Contributor Author

alja commented Aug 18, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@alja
Copy link
Contributor Author

alja commented Aug 18, 2014

Hi All,

In PR #4840 I made a change which cause a crash in cmsShow startup. The change is already integrated in CMSSW_7_1_6.

This PR fixes the bug pulled in 4840. Please merge this change when you can.

Thanks,
Alja

davidlange6 added a commit that referenced this pull request Aug 26, 2014
7x improvements in Fireworks reco geometry tag info
@davidlange6 davidlange6 merged commit 0b3bd08 into cms-sw:CMSSW_7_1_X Aug 26, 2014
@alja alja deleted the recogeo4b branch May 11, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants