Do not throw an exception when ROOT reports a missing dictionary problem #4931
Conversation
When initializing a BranchDescription from a ROOT dictionary, if there is an exception thrown we now add to the context information which branch had the problem.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X. Do not throw an exception when ROOT reports a missing dictionary problem It involves the following packages: DataFormats/Provenance @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. |
In the case where ROOT prints a message about a missing collection proxy we no longer throw an exception. This was needed to handle the case of reading an old file using a release for which a class in that file no longer exists. The framework doesn't need the exception since it has other ways of detecting the missing dictionary and then take appropriate action.
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. |
|
Hi Chris, I started the tests including 4.78 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
Do not throw an exception when ROOT reports a missing dictionary problem.
1 similar comment
In the case where ROOT prints an error message about a missing collection proxy we no longer throw an exception. This was needed to handle the case of reading an old file using a release for which a class in that
file no longer exists. The framework doesn't need the exception since it has other ways of detecting the missing dictionary and then take appropriate action.