Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct xml schema #4940

Merged
merged 1 commit into from Aug 13, 2014
Merged

Correct xml schema #4940

merged 1 commit into from Aug 13, 2014

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Aug 13, 2014

  • Make sure the xml description is correctly written

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_7_2_X.

Correct xml schema

It involves the following packages:

Geometry/ForwardCommonData
Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@ianna
Copy link
Contributor Author

ianna commented Aug 13, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Aug 13, 2014
@ktf ktf merged commit 1d4a0c2 into cms-sw:CMSSW_7_2_X Aug 13, 2014
@ktf
Copy link
Contributor

ktf commented Aug 13, 2014

Can we have some test which validates schemas, please?

@ianna ianna deleted the schema-valid branch October 26, 2015 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants