New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker geom det #4947
Tracker geom det #4947
Conversation
A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_2_X. Tracker geom det It involves the following packages: Alignment/CommonAlignment @civanch, @diguida, @StoyanStoynev, @lveldere, @ianna, @mdhildreth, @cmsbuild, @alja, @Dr15Jones, @rcastello, @cerminar, @slava77, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
Hi Vincenzo, |
No regression expected. No regression observed. |
uhm, fastsim (5.1 and 50101.0) came out with differences. running them on higher stats to see if it's serious. |
-1 Tested at: dcddd70 ---> test runtestUtilAlgos had ERRORS you can see the results of the tests here: |
do not want to apply excessive pressure for the pending signature. |
+1 |
Bypassing AlCa on holidays. |
Following the presentation at the ALCA meeting about APE for muons
https://indico.cern.ch/event/294021/contribution/1/material/slides/0.pdf
It became clear that the GeomDet inheritance tree shall be split between Muon and Tracker at root level.
This requires the coalescence of GeomDetUnit into GeomDet and the introduction of two root classes
TrackerGeomDet and MuonGeomDet.
This PR prepares the infrastructure and implements the Tracker components, leaving to the Muon POG to take care of their specific parts (and if necessary to generalize and extend some of the APE components).
It is quite obvious at this point that the Tracking Geometry infrastructure, as designed in the early days, is not able anymore to support new requirements (it hardly supported alignment requirements even when designed).
Most probably a general clean-up would be very welcome. Unfortunately the amount of code to modify is, as usual, enormous and residing mostly in non critical areas. So I suspect we have just to live with it.