Fix clang problems in JetMETCorrections/Type1MET #4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to explicitly add universal initializer syntax to instantiation of a temporary const object.
clang complained that 'sign' was not being used because the templated function which used it was not being instantiated in a given object file. However, since declaring unnamed namespaces in a header is a bad idea anyway, I moved one function to be a static member of the template (since it was also templated on the same type) and put 'sign' into a unique namespace.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X. Fix clang problems in JetMETCorrections/Type1MET It involves the following packages: JetMETCorrections/Type1MET @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks. |
|
Bypassing AT. Complain if not ok. |
ktf
added a commit
that referenced
this pull request
Aug 16, 2014
…ctionsType1MET Fix clang problems in JetMETCorrections/Type1MET
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed compilation problems in JetMETCorrections/Type1MET when it was compiled under clang.