Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert broken tau fixes (71x) #4987

Closed
wants to merge 2 commits into from
Closed

Revert broken tau fixes (71x) #4987

wants to merge 2 commits into from

Conversation

bendavid
Copy link
Contributor

Reverts recent sets of changes to Tauola++ interface which caused undecayed taus in rare cases and therefore crashes in the validation sequence.

This reverts pull requests:
#4835
#4933

(The equivalent reverts for 72x are in #4986)

@bendavid
Revert "Merge pull request cms-sw#4933 from inugent/7_1_X_lifetime_pa…
d5f6ef0 
…tch"

This reverts commit 289662f, reversing
changes made to 70e681b.
@bendavid
Revert "Merge pull request cms-sw#4835 from inugent/TauolaLifetimePat…
2a87bdb 
…ch_7_1_X"

This reverts commit 8e6b1bb, reversing
changes made to 1d90f5a.
@bendavid
Copy link
Contributor Author

@inugent fyi

@bendavid
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

+1
Tested at: 2a87bdb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4987/1889/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed generators-approved orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_7_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bendavid @cmsbuild @davidlange6