Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local covariances for shashlik #5024

Merged
merged 2 commits into from Aug 21, 2014

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Aug 21, 2014

Allow shashlik local coordinates to be transformed for sigma ieta ieta calculation.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC.

Fix local covariances for shashlik

It involves the following packages:

RecoEcal/EgammaCoreTools

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

@lgray Is this everything you wanted in the next release or is there more to come tomorrow?

@lgray
Copy link
Contributor Author

lgray commented Aug 21, 2014

With the addition Sasha's fix, this should be it. I'm checking to make sure there isn't any other weirdness in code that calls this stuff.

@cmsbuild
Copy link
Contributor

Pull request #5024 was updated. @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please check and sign again.

@lgray
Copy link
Contributor Author

lgray commented Aug 21, 2014

@mark-grimes Found a few more things in downstream code, fixed up now.

@mark-grimes
Copy link

merge

All looks good as far as I can see.

cmsbuild added a commit that referenced this pull request Aug 21, 2014
@cmsbuild cmsbuild merged commit 058f3a1 into cms-sw:CMSSW_6_2_X_SLHC Aug 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants