Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #5036

Merged
merged 1 commit into from Aug 25, 2014
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Aug 25, 2014

  • Unused legacy code

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_7_2_X.

Remove unused code

It involves the following packages:

DetectorDescription/Core

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

-1
Tested at: 8634c31
When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5036/684/summary.html

@ktf
Copy link
Contributor

ktf commented Aug 25, 2014

Looks like a das glitch. Merging.

ktf added a commit that referenced this pull request Aug 25, 2014
@ktf ktf merged commit acd65fe into cms-sw:CMSSW_7_2_X Aug 25, 2014
@ianna ianna deleted the remove-unused-hierarchy-utils branch October 26, 2015 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants