Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE front shielding #5063

Merged
merged 2 commits into from Aug 28, 2014
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Aug 26, 2014

  • Remove Al structure

@ianna
Copy link
Contributor Author

ianna commented Aug 26, 2014

+1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_6_2_X_SLHC.

EE front shielding

It involves the following packages:

Fireworks/Geometry
Geometry/EcalCommonData

@Dr15Jones, @cmsbuild, @alja, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @alja, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

@ianna, presumably this is instead of #5028, correct?

@ianna
Copy link
Contributor Author

ianna commented Aug 26, 2014

@mark-grimes - yes, please, do not take the #5028

@alja
Copy link
Contributor

alja commented Aug 27, 2014

@ianna

Why don't use dumpSimGeometry_cfg.py? What is the different use case for dumpSimGeometryXML_cfg.py?

@alja
Copy link
Contributor

alja commented Aug 27, 2014

-1

Can we please hold this PR till usage of dumpSimGeometryXML_cfg.py/dumpSimGeometry_cfg.py is cleared out. I want to avoid duplication in maintenance.

@alja
Copy link
Contributor

alja commented Aug 27, 2014

+1
I had a look and can see dumpSimGeometryXML_cfg.py is more generic version of dumpSimGeometry_cfg.py.

@ianna
It looks like dumpSimGeometry_cfg.py should be removed or dumpSimGeometryXML_cfg.py be renamed to dumpSimGeometry_cfg.py

Does the same change goes to 7x?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @fratnikov, @mark-grimes can you please take care of it?

@ianna
Copy link
Contributor Author

ianna commented Aug 27, 2014

@alja - yes, the directory structure is the same in 7xx. I'd also add a DB GT in the command line. But it's not urgent.

@mark-grimes
Copy link

I've separated off the geometry issue into a separate pull request #5074. Could you continue the dumpSimGeometry discussion on #5061, and anything to do with the shielding on #5074, so that the two issues are discussed separately?

@ianna could you close this please? Thanks.

@ianna
Copy link
Contributor Author

ianna commented Aug 27, 2014

@mark-grimes - this one is fully signed - why it cannot be integrated in an IB?

@alja
Copy link
Contributor

alja commented Aug 27, 2014

+1

We have cleared the dumpSimGeometry discussion.

@mark-grimes
Copy link

merge

cmsbuild added a commit that referenced this pull request Aug 28, 2014
@cmsbuild cmsbuild merged commit 90b52e5 into cms-sw:CMSSW_6_2_X_SLHC Aug 28, 2014
@ianna ianna deleted the fix-EE-front-shielding branch October 26, 2015 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants