Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch on BTag from candidates in reco and provide corresponding PAT tools #5064

Merged

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Aug 26, 2014

This PR runs one candidate based tagging (exploiting the new fwk) in RECO.
The corresponding code in jetTools.py (and related PAT stuff) is also added.

@ferencek @pvmulder

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for CMSSW_7_2_X.

Switch on BTag from candidates in reco and provide corresponding PAT tools

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos
RecoBTag/Configuration
RecoBTag/ImpactParameter
RecoBTag/SecondaryVertex

@nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @mmarionncern, @nhanvtran, @schoef, @ferencek, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@@ -31,8 +31,13 @@
softPFMuonBJetTags *
softPFElectronsTagInfos*
softPFElectronBJetTags

*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this just after softPFElectronBJetTags for better readability

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are working in parallel on another PR where I am modifying this file. If you agree can include this minor change in the next PR (it is just cosmetics anyway).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@StoyanStoynev
Copy link
Contributor

+1
Tested c81f84b on top of CMSSW_7_2_X_2014-08-26-1400. No differences in standard plots (FWlite and DQM based scripts; extended matrix tests). New b-tagging modules (input from "Candidates") are run, here timing from wf 202:
pfImpactParameterTagInfos 38.8019 ms/ev
pfSecondaryVertexTagInfos 4.33015 ms/ev
pfCombinedSecondaryVertexBJetTags 1.09675 ms/ev
and new branches appear in the event content as intended (bytes/event in wf 202):
new: recoCandidateedmPtrsrecoJetTagInforecoIPTagInfos_pfImpactParameterTagInfos__RECO. 11655
new: recoTracks_pfImpactParameterTagInfos_ghostTracks_RECO. 7323.95
new: recoCandidateedmPtrsrecoJetTagInforecoIPTagInforecoVertexCompositePtrCandidaterecoTemplatedSecondaryVertexTagInfos_pfSecondaryVertexTagInfos__RECO. 714.445
new: recoJetedmRefToBaseProdTofloatsAssociationVector_pfCombinedSecondaryVertexBJetTags__RECO. 106.36

A couple of fixes in PatCandidates and b-tag plugins do not change the standard reco performance.

@ferencek
Copy link
Contributor

ferencek commented Sep 1, 2014

@monttj, @vadler, can you guys sign this one so we can go ahead with another PR that requires this one to be merged first. Many thanks!

@monttj
Copy link
Contributor

monttj commented Sep 2, 2014

+1
PAT workflow runs fine.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Sep 2, 2014
…MSSW_7_2_0_pre4

Switch on BTag from candidates in reco and provide corresponding PAT tools
@ktf ktf merged commit 42efbba into cms-sw:CMSSW_7_2_X Sep 2, 2014
@ferencek ferencek deleted the NewFwk-PFCandsInRECO-from-CMSSW_7_2_0_pre4 branch September 18, 2014 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants