Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip cluster on/off track dqm@hlt #5076

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Aug 27, 2014

it was #4920

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_2_X.

strip cluster on/off track dqm@hlt

It involves the following packages:

DQM/SiStripMonitorCluster
DQM/SiStripMonitorTrack
DQMOffline/Trigger
RecoTracker/TrackProducer

@nclopezo, @StoyanStoynev, @danduggan, @rovere, @cmsbuild, @deguio, @slava77, @ojeda, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @battibass, @threus, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @gpetruc, @cerati, @venturia, @trocino, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
It, 53baa20 , is identical to #4920 (except ordering of few lines
and a fix discussed above). The previous version was reviewed and signed off. Jenkins here show no diffs as well (except one "fake" I saw in at least one other PR but not in local running; see "fail" in wf 1306 comparisons).

@deguio
Copy link
Contributor

deguio commented Aug 29, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Aug 29, 2014
…stripClusterDQM@HLT_ON-OFFtrack

Strip cluster on/off track dqm@hlt
@ktf ktf merged commit 6e18eed into cms-sw:CMSSW_7_2_X Aug 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants