Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database compatibility additions for boost I/O so that records intended ... #5138

Merged
merged 1 commit into from Sep 4, 2014

Conversation

igv4321
Copy link
Contributor

@igv4321 igv4321 commented Sep 2, 2014

This includes a number of changes intended for storing conditions
objects serialized with boost.serialization into v1 database in case
genreflex/root I/O can not process the data structures. The idea
is to make a simple string buffer and use it for boost I/O. What
stored in the database is the blob representation of this buffer.

@cmsbuild cmsbuild added this to the Next CMSSW_7_2_X milestone Sep 2, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2014

A new Pull Request was created by @igv4321 for CMSSW_7_2_X.

database compatibility additions for boost I/O so that records intended ...

It involves the following packages:

CondCore/HcalPlugins
CondFormats/DataRecord
CondFormats/HcalObjects
CondTools/Hcal

@apfeiffer1, @diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @ggovi can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2014

2 similar comments
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2014

@apfeiffer1
Copy link
Contributor

+1
as discussed privately, this is a temporary solution for compatibility with CondDBv1 and will be reverted once CondDB V1 is frozen.

@diguida
Copy link
Contributor

diguida commented Sep 4, 2014

+1
@apfeiffer1 fine with me.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

nclopezo added a commit that referenced this pull request Sep 4, 2014
database compatibility additions for boost I/O so that records intended for db v2 could be stored in db v1
@nclopezo nclopezo merged commit 8f7c82c into cms-sw:CMSSW_7_2_X Sep 4, 2014
@igv4321 igv4321 deleted the db-compatibility-fix branch September 12, 2014 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants