Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of tau-decay bug fix and exotica tuning #5146

Merged
merged 7 commits into from Sep 5, 2014

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Sep 3, 2014

This PR include back-port of PR 4877 and 5119 done by hand:

  1. Fixed problem of rare crash in tau-decay validation when tau decay happens outside volume where generators decay all unstable particle. This rare cases of large decay range due boost of tau, D, B more frequently happens at 13 TeV.
  2. A fragment used for simulation of exotica has been revised and cleaned up according to 7_X_Y SIM.
    Custom Physics List printpout at initialisation is moved from debug to info and a bit cleaned up.
    GFlash is added to the list of processes in process enumeration table.
  3. New lumi monitors have small acceptance, so ordinary simulation is very ineffective. In this PR a new filter allowing selection of primary particles is added. By default this filter is not enabled, so no effect for mainstream production.
  4. changed HF SL for 2011-2012 reprocessing is taken out - will be in a separate PR

@cmsbuild cmsbuild added this to the Next CMSSW_7_1_X milestone Sep 3, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2014

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_1_X.

Backport of tau-decay bug fix and exotica tuning

It involves the following packages:

SimG4Core/Application
SimG4Core/CustomPhysics
SimG4Core/Generators
SimG4Core/Physics

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor Author

civanch commented Sep 3, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2014

-1
Tested at: 13a3b70
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-09-03-0200/src/SimG4Core/Physics/src/G4ProcessTypeEnumerator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-09-03-0200/src/SimG4Core/Physics/src/PhysicsList.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-09-03-0200/src/SimG4Core/Physics/src/PhysicsListFactory.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-09-03-0200/src/SimG4Core/Application/test/SimHitCaloHitDumper.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-09-03-0200/src/SimG4Core/Application/test/SimTrackSimVertexDumper.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-09-03-0200/src/SimG4Core/Generators/src/Generator.cc:3:62: fatal error: SimG4Core/Generators/interface/LumiMonitorFilter.h: No such file or directory
 #include "SimG4Core/Generators/interface/LumiMonitorFilter.h"
                                                              ^
compilation terminated.
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-09-03-0200/src/SimG4Core/Generators/src/Generator.cc:3:62: fatal error: SimG4Core/Generators/interface/LumiMonitorFilter.h: No such file or directory
 #include "SimG4Core/Generators/interface/LumiMonitorFilter.h"


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5146/1935/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@civanch
Copy link
Contributor Author

civanch commented Sep 3, 2014

+1
Sorry, new class was not committed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 5, 2014
Backport of tau-decay bug fix and exotica tuning
@davidlange6 davidlange6 merged commit 3f92395 into cms-sw:CMSSW_7_1_X Sep 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants