Dqm multi threading offline clients 720 v2

[nancymarinelli]

This finishes up PR 5161 and addresses Marco's comments.

[cmsbuild]

A new Pull Request was created by @nancymarinelli for CMSSW_7_2_X.

Dqm multi threading offline clients 720 v2

It involves the following packages:

DQMOffline/EGamma

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[deguio]

hello @nancymarinelli
sorry to bother again. please go through the code, search for dbe_ and remove all the instances.
thanks,
F.

[nancymarinelli]

Ciao,
But I did it. I only left those connected with opening and saving in a file. A long time ago you told me that I could keep them.
If I cannot, well, I will take them out. But in this way it cannot be used in standalone.
Nancy

---

Nancy Marinelli

Research Associate Professor
University of Notre Dame, IN, US

CERN, Bdg 40/3-A01, 1211 Geneva,

SWITZERLAND

Phone +41-22-76-70809, fax +41-22-76-78940

From: deguio <notifications@github.commailto:notifications@github.com>
Reply-To: cms-sw/cmssw <reply@reply.github.commailto:reply@reply.github.com>
Date: Fri, 5 Sep 2014 02:47:57 -0700
To: cms-sw/cmssw <cmssw@noreply.github.commailto:cmssw@noreply.github.com>
Cc: Nancy Marinelli <nancy.marinelli@cern.chmailto:nancy.marinelli@cern.ch>
Subject: Re: [cmssw] Dqm multi threading offline clients 720 v2 (#5172)

hello @nancymarinellihttps://github.com/nancymarinelli
sorry to bother again. please go through the code, search for dbe_ and remove all the instances.
thanks,
F.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5172#issuecomment-54605108.

[deguio]

ciao @nancy,
the code can be used anyway in standalone by adding the DQMFileSaver in the sequence. this is the right way to go. we decided to remove any direct call from modules to the DQMStore.

thanks for understanding,
F.

[nancymarinelli]

Ok, I will queue another PR possibly later today to fix 5172.
Do I understand that 5172 is refused anyway ?

Nancy

---

Nancy Marinelli

Research Associate Professor
University of Notre Dame, IN, US

CERN, Bdg 40/3-A01, 1211 Geneva,

SWITZERLAND

Phone +41-22-76-70809, fax +41-22-76-78940

From: deguio <notifications@github.commailto:notifications@github.com>
Reply-To: cms-sw/cmssw <reply@reply.github.commailto:reply@reply.github.com>
Date: Fri, 5 Sep 2014 03:00:08 -0700
To: cms-sw/cmssw <cmssw@noreply.github.commailto:cmssw@noreply.github.com>
Cc: Nancy Marinelli <nancy.marinelli@cern.chmailto:nancy.marinelli@cern.ch>
Subject: Re: [cmssw] Dqm multi threading offline clients 720 v2 (#5172)

ciao @nancyhttps://github.com/nancy,
the code can be used anyway in standalone by adding the DQMFileSaver in the sequence. this is the right way to go. we decided to remove any direct call from modules to the DQMStore.

thanks for understanding,
F.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5172#issuecomment-54606216.

[deguio]

@nancymarinelli
it is enough if you push another commit to this branch. the PR will update automatically.
ciao,
F.

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

[cmsbuild]

+1
Tested at: 59d0f51
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5172/827/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5172/827/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).