Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7x: fix ecal cell orientation in TGeo geometry #5175

Merged
merged 19 commits into from Sep 16, 2014

Conversation

alja
Copy link
Contributor

@alja alja commented Sep 4, 2014

Fix positioning of ecal cells.
Set TGeoVolume color as defined in its TGeoMaterial color.

@cmsbuild cmsbuild added this to the Next CMSSW_7_1_X milestone Sep 4, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2014

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_1_X.

7x: fix ecal cell orientation in TGeo geometry

It involves the following packages:

Fireworks/Geometry

@cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2014

@alja
Copy link
Contributor Author

alja commented Sep 9, 2014

+1

@alja
Copy link
Contributor Author

alja commented Sep 9, 2014

This PR goes on top of #5246

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 16, 2014
7x: fix ecal cell orientation in TGeo geometry
@davidlange6 davidlange6 merged commit f661b24 into cms-sw:CMSSW_7_1_X Sep 16, 2014
@alja alja deleted the tgeo-colors branch May 11, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants