Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt oot pileup #5179

Merged
merged 3 commits into from Sep 13, 2014
Merged

Alt oot pileup #5179

merged 3 commits into from Sep 13, 2014

Conversation

igv4321
Copy link
Contributor

@igv4321 igv4321 commented Sep 5, 2014

Created a heterogeneous collection for hcal oot pileup subtraction objects which is compatible with both database versions. Will be able to switch to this collection for 7_3_X.

@cmsbuild cmsbuild added this to the Next CMSSW_7_2_X milestone Sep 5, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2014

A new Pull Request was created by @igv4321 for CMSSW_7_2_X.

Alt oot pileup

It involves the following packages:

CondCore/HcalPlugins
CondFormats/DataRecord
CondFormats/HcalObjects
CondTools/Hcal

@apfeiffer1, @diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @ggovi can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2014

@cmsbuild
Copy link
Contributor

@apfeiffer1
Copy link
Contributor

+1
again.
Though it is strange, according to the discussion log here, it says that I signed it 4 days ago and the bot claimed to have removed the db-pending label 3 days ago - yet I still see it as "db pending" ... :(

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

davidlange6 added a commit that referenced this pull request Sep 13, 2014
@davidlange6 davidlange6 merged commit 3b316ce into cms-sw:CMSSW_7_2_X Sep 13, 2014
@igv4321 igv4321 deleted the alt-oot-pileup branch October 5, 2014 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants