Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Susy hlt from7 2 0 pre5 #5196

Merged
merged 9 commits into from Sep 8, 2014
Merged

Susy hlt from7 2 0 pre5 #5196

merged 9 commits into from Sep 8, 2014

Conversation

jgran
Copy link
Contributor

@jgran jgran commented Sep 5, 2014

Updates to SUSY HLT Validation to cover 4 proposed triggers.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2014

A new Pull Request was created by @jgran (Jason Gran) for CMSSW_7_2_X.

Susy hlt from7 2 0 pre5

It involves the following packages:

HLTriggerOffline/SUSYBSM

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@deguio
Copy link
Contributor

deguio commented Sep 5, 2014

-1
efficiencies should be calculated in the harvesting step.
please refer to:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/ThreadedDQM

for the implementation of the DQMEDHarvester
F.

@deguio
Copy link
Contributor

deguio commented Sep 5, 2014

please consider using the DQMGenericClient for the harvesting.
see for example:
https://github.com/cms-sw/cmssw/blob/CMSSW_7_2_X/DQMServices/Examples/python/test/DQMExample_GenericClient_cfi.py
thanks,
F.

@jgran
Copy link
Contributor Author

jgran commented Sep 6, 2014

Thank you for the comments Federico. I have implemented a GenericClient to do the efficiencies as you suggest. Please take another look.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2014

@deguio
Copy link
Contributor

deguio commented Sep 8, 2014

+1
not mandatory. just wanted to make sure. I will ask you to report at the DQM meeting about the development you are doing and the plans for the future.

ciao and thanks,
F.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

nclopezo added a commit that referenced this pull request Sep 8, 2014
HLTriggerOffline/SUSYBSM -- Susy hlt from7 2 0 pre5
@nclopezo nclopezo merged commit 795724a into cms-sw:CMSSW_7_2_X Sep 8, 2014
@parbol
Copy link
Contributor

parbol commented Sep 8, 2014

Thank you. We will be pleased the present our plans in one of the incoming DQM meetings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants