Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Ecal Local Reconstruction with Multifit #5197

Merged
merged 40 commits into from Sep 9, 2014
Merged

New Ecal Local Reconstruction with Multifit #5197

merged 40 commits into from Sep 9, 2014

Commits on Aug 30, 2014

  1. Add (and activate) multifit reconstruction

    @bendavid
    bendavid committed Aug 30, 2014
    Copy the full SHA
    6fed59e View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2014

  1. add the cfg starting from raw

    @emanueledimarco
    emanueledimarco committed Aug 31, 2014
    Copy the full SHA
    602e95f View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2014

  1. - Add the 10 pulses amplitudes and uncertainties to the transient unc… 

    …alibrated rechit.

- Remove the outof time energy and chi2, no more needed since the OOT energy is subtracted
    @emanueledimarco
    emanueledimarco committed Sep 1, 2014
    Copy the full SHA
    ff1836a View commit details
    Browse the repository at this point in the history

  2. change the constents of the 13 bits reserved to OOT energy to the ene… 

    …rgy uncertainty from the multipulse fit
    @emanueledimarco
    emanueledimarco committed Sep 1, 2014
    Copy the full SHA
    06932c1 View commit details
    Browse the repository at this point in the history

  3. change the uncalibrated rechit dataformats for the migration to the m… 

    …ultifit amplitude reco
    @emanueledimarco
    emanueledimarco committed Sep 1, 2014
    Copy the full SHA
    5ff7e48 View commit details
    Browse the repository at this point in the history

  4. change the uncalibrated rechit dataformats for the migration to the m… 

    …ultifit amplitude reco
    @emanueledimarco
    emanueledimarco committed Sep 1, 2014
    Copy the full SHA
    ea51885 View commit details
    Browse the repository at this point in the history

  5. change the container for the alternative amplitude reco after the mul… 

    …tifit migration
    @emanueledimarco
    emanueledimarco committed Sep 1, 2014
    Copy the full SHA
    e269455 View commit details
    Browse the repository at this point in the history

  6. migration of the Ecal(Uncalib)RecHit dataformats to the new format af… 

    …ter the multifit migration
    @emanueledimarco
    emanueledimarco committed Sep 1, 2014
    Copy the full SHA
    ee8913e View commit details
    Browse the repository at this point in the history

  7. cleanup the cfg

    @emanueledimarco
    emanueledimarco committed Sep 1, 2014
    Copy the full SHA
    37ad02f View commit details
    Browse the repository at this point in the history

  8. add some code to set the flags of kPoorReco and kOutOfTime (the secon… 

    …d is not active at the moment)
    @emanueledimarco
    emanueledimarco committed Sep 1, 2014
    Copy the full SHA
    86eaba7 View commit details
    Browse the repository at this point in the history

  9. comment out the kPoorReco flag

    @emanueledimarco
    emanueledimarco committed Sep 1, 2014
    Copy the full SHA
    b9a6bb3 View commit details
    Browse the repository at this point in the history

  10. migrate from minuit to inline TMatrix/TVector-based NNLS algorithm

    @bendavid
    bendavid committed Sep 1, 2014
    Copy the full SHA
    55a061c View commit details
    Browse the repository at this point in the history

  11. restore deprecated accessors to avoid interface incompatibility

    @bendavid
    bendavid committed Sep 1, 2014
    Copy the full SHA
    3913455 View commit details
    Browse the repository at this point in the history

  12. fix indices for out of time energy in case not all bxs are active (mi… 

    …ght happen in the future)
    @bendavid
    bendavid committed Sep 1, 2014
    Copy the full SHA
    5dce33e View commit details
    Browse the repository at this point in the history

  13. further performance optimizations

    @bendavid
    bendavid committed Sep 1, 2014
    Copy the full SHA
    0a6ccaf View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2014

  1. make minimizer a data member of the algo so that memory is only alloc… 

    …ated once
    @bendavid
    bendavid committed Sep 2, 2014
    Copy the full SHA
    f5d71ab View commit details
    Browse the repository at this point in the history

  2. move the inputs to the python files

    @emanueledimarco
    emanueledimarco committed Sep 2, 2014
    Copy the full SHA
    6f36fd9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'ecalMultifit_minimal720p4' of github.com:bendavid/cmssw… 

    … into ecalMultifit_minimal720p4

Merge the NNLS implementation with the DataFormats changes and the python configuration
    @emanueledimarco
    emanueledimarco committed Sep 2, 2014
    Copy the full SHA
    e2ba69f View commit details
    Browse the repository at this point in the history

  4. remove the uncertainties on the OOT pulses amplitudes

    @emanueledimarco
    emanueledimarco committed Sep 2, 2014
    Copy the full SHA
    b46493e View commit details
    Browse the repository at this point in the history

  5. add minos-like uncertainty computation

    @bendavid
    bendavid committed Sep 2, 2014
    Copy the full SHA
    6a0fd2a View commit details
    Browse the repository at this point in the history

  6. cleanup printout statements (and issue LogWarnings where appropriate)

    @bendavid
    bendavid committed Sep 2, 2014
    Copy the full SHA
    005de8f View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2014

  1. bug fix on the OOT BXs amplitude assignement

    @emanueledimarco
    emanueledimarco committed Sep 3, 2014
    Copy the full SHA
    c39179b View commit details
    Browse the repository at this point in the history

  2. change the time estimation with the weights, once subtracted the OOT PU

    @emanueledimarco
    emanueledimarco committed Sep 3, 2014
    Copy the full SHA
    5c933d2 View commit details
    Browse the repository at this point in the history

  3. fix remaining small problem with bx indices

    @bendavid
    bendavid committed Sep 3, 2014
    Copy the full SHA
    b6f46b3 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2014

  1. pass set by const reference

    @bendavid
    bendavid committed Sep 4, 2014
    Copy the full SHA
    8426f04 View commit details
    Browse the repository at this point in the history

  2. update pulse templates and covariance matrices

    @bendavid
    bendavid committed Sep 4, 2014
    Copy the full SHA
    0dee3f1 View commit details
    Browse the repository at this point in the history

  3. fix input collections for default sequnce

    @bendavid
    bendavid committed Sep 4, 2014
    Copy the full SHA
    491f225 View commit details
    Browse the repository at this point in the history

  4. implement the weights for time reco, but turned off and configurable

    @emanueledimarco
    emanueledimarco committed Sep 4, 2014
    Copy the full SHA
    7b25da1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'ecalMultifit_minimal720p4' of github.com:bendavid/cmssw… 

    … into ecalMultifit_minimal720p4

Needed to add both the timing algorithm on pu-subtracted pulse shape and the newest complete covariance matrices from simulation
    @emanueledimarco
    emanueledimarco committed Sep 4, 2014
    Copy the full SHA
    f96c361 View commit details
    Browse the repository at this point in the history

  6. fix collection names in validation sequence

    @bendavid
    bendavid committed Sep 4, 2014
    Copy the full SHA
    8a14d87 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2014

  1. allow turning off the calculation of the uncertainties

    @emanueledimarco
    emanueledimarco committed Sep 5, 2014
    Copy the full SHA
    8f1563a View commit details
    Browse the repository at this point in the history

  2. allow turning off the calculation of the uncertainties

    @emanueledimarco
    emanueledimarco committed Sep 5, 2014
    Copy the full SHA
    b2cdac5 View commit details
    Browse the repository at this point in the history

  3. add the time profiler service

    @emanueledimarco
    emanueledimarco committed Sep 5, 2014
    Copy the full SHA
    a54efe1 View commit details
    Browse the repository at this point in the history

  4. fix remaining input collection names

    @bendavid
    bendavid committed Sep 5, 2014
    Copy the full SHA
    69720c9 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2014

  1. fix event content for ecal local reco

    @bendavid
    bendavid committed Sep 6, 2014
    Copy the full SHA
    0c02475 View commit details
    Browse the repository at this point in the history

  2. fix typo in unit test

    @bendavid
    bendavid committed Sep 6, 2014
    Copy the full SHA
    b745126 View commit details
    Browse the repository at this point in the history

  3. move to the new multifit ECAL uncalibrated rechit collection for phys… 

    …ical hits
    @emanueledimarco
    emanueledimarco committed Sep 6, 2014
    Copy the full SHA
    ee498a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2014

  1. remove obsolete accessors from EcalRecHit and ensure consistent behav… 

    …iour when reading old files
    @bendavid
    bendavid committed Sep 8, 2014
    Copy the full SHA
    17118ec View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2014

  1. revert class version and iorules gymnastics which were not working pr… 

    …operly
    @bendavid
    bendavid committed Sep 9, 2014
    Copy the full SHA
    fa66873 View commit details
    Browse the repository at this point in the history

  2. restore only the class version increment for the EcalRecHit

    @bendavid
    bendavid committed Sep 9, 2014
    Copy the full SHA
    24ef838 View commit details
    Browse the repository at this point in the history