Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix charge flip #5205

Merged
merged 1 commit into from Sep 8, 2014
Merged

fix charge flip #5205

merged 1 commit into from Sep 8, 2014

Conversation

degrutto
Copy link
Contributor

@degrutto degrutto commented Sep 6, 2014

fix charge flip in CSCTF simulation

@cmsbuild cmsbuild added this to the Next CMSSW_7_2_X milestone Sep 6, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2014

A new Pull Request was created by @degrutto (michele de gruttola) for CMSSW_7_2_X.

fix charge flip

It involves the following packages:

L1Trigger/CSCTrackFinder

@cmsbuild, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2014

+1
Tested at: 8f3ef86
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5205/847/summary.html

@mulhearn
Copy link
Contributor

mulhearn commented Sep 8, 2014

+1

cheers,
mike

On Sep 8, 2014, at 9:40 AM, cmsbuild notifications@github.com wrote:

+1
Tested at: 8f3ef86
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5205/847/summary.html

—
Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

nclopezo added a commit that referenced this pull request Sep 8, 2014
@nclopezo
Merge pull request #5205 from degrutto/new-CSCTF_72X_plusChargeFlipFix
1ef07bf 
L1Trigger/CSCTrackFinder -- fix charge flip
@nclopezo nclopezo merged commit 1ef07bf into cms-sw:CMSSW_7_2_X Sep 8, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2014

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5205/847/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed l1-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@degrutto @cmsbuild @mulhearn @nclopezo