Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in ME0SegmentMatcher #5210

Merged

Conversation

mark-grimes
Copy link

Fixes a small memory leak in ME0SegmentMatcher that looks to be proportional to the number of tracks. At 140 pileup this is about half a Mb per event.
Plot of retained memory before an after below.

Leak pointed out by David Lange.

me0segmentmatcher

(EDIT - I've just realised I labelled the series incorrectly. "After" is of course the line with flat memory use)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2014

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Fix memory leak in ME0SegmentMatcher

It involves the following packages:

RecoMuon/MuonIdentification

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @bellan, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

merge

cmsbuild added a commit that referenced this pull request Sep 8, 2014
@cmsbuild cmsbuild merged commit 5e548ce into cms-sw:CMSSW_6_2_X_SLHC Sep 8, 2014
@mark-grimes mark-grimes deleted the fixME0SegmentMatcherMemory branch September 8, 2014 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants