Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Assign template paths to their PD, and remove from GRUN, CMSHLT-... #5228

Merged
merged 1 commit into from Sep 9, 2014
Merged

Revert "Assign template paths to their PD, and remove from GRUN, CMSHLT-... #5228

merged 1 commit into from Sep 9, 2014

Conversation

nclopezo
Copy link
Contributor

@nclopezo nclopezo commented Sep 9, 2014

Reverts #5226

@nclopezo
Copy link
Contributor Author

nclopezo commented Sep 9, 2014

Sorry, I accidentally merged #5226 without running the tests I will run them, and If they fail I will merge this PR.

@cmsbuild cmsbuild added this to the Next CMSSW_7_2_X milestone Sep 9, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2014

A new Pull Request was created by @nclopezo (David Mendez) for CMSSW_7_2_X.

Revert "Assign template paths to their PD, and remove from GRUN, CMSHLT-...

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@perrotta
Copy link
Contributor

perrotta commented Sep 9, 2014

+1
(just in case is needed...)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

davidlange6 added a commit that referenced this pull request Sep 9, 2014
@davidlange6
Merge pull request #5228 from cms-sw/revert-5226-templatePdForRun2Hlt
52dfcab 
Revert "Assign template paths to their PD, and remove from GRUN, CMSHLT-...
@davidlange6 davidlange6 merged commit 52dfcab into CMSSW_7_2_X Sep 9, 2014
@Martin-Grunewald
Copy link
Contributor

Why on earth would we want to revert PR #5226?
TSG for sure does NOT want to revert it, we want
#5226 to be IN! I am confused on why @nclopezo
made this PR in the first place... :(
Please revert the reversal so that #5226 is back in!

@davidlange6
Copy link
Contributor

ah, well, I guess HLT should not have signed it… re-reverting

On Sep 10, 2014, at 6:56 AM, Martin Grunewald notifications@github.com
wrote:

Why on earth would we want to revert PR #5226?
TSG for sure does NOT want to revert it, we want
#5226 to be IN! I am confused on why @nclopezo
made this PR in the first place... :(
Please revert the reversal so that #5226 is back in!

—
Reply to this email directly or view it on GitHub.

@davidlange6 davidlange6 mentioned this pull request Sep 10, 2014
Merged
@Martin-Grunewald
Copy link
Contributor

Thanks, David!

@nclopezo
Copy link
Contributor Author

Hi All,

I created this PR because I suspected that #5226 was going to cause this error in the relvals:

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc481/CMSSW_7_2_X_2014-09-09-1400/pyRelValMatrixLogs/run/1303.0_ProdQCD_Pt_3000_3500_13+ProdQCD_Pt_3000_3500_13+DIGIUP15PROD1+RECOPRODUP15/step1_ProdQCD_Pt_3000_3500_13+ProdQCD_Pt_3000_3500_13+DIGIUP15PROD1+RECOPRODUP15.log

@nclopezo nclopezo deleted the revert-5226-templatePdForRun2Hlt branch November 26, 2014 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed hlt-approved tests-pending
Projects
None yet
Milestone
Next CMSSW_7_2_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nclopezo @cmsbuild @perrotta @Martin-Grunewald @davidlange6