Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune adjustments to run2 menu #5258

Merged
merged 3 commits into from Sep 11, 2014

Conversation

perrotta
Copy link
Contributor

Just a couple of small adjustment to our latest pull request:

Both fixes change nothing to the current workflows

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for CMSSW_7_2_X.

Fine tune adjustments to run2 menu

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@perrotta
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

-1

Tested at: 3ff8d7e
I ran the usual tests and I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5258/892/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (but tests are reportedly failing).

@fwyzard
Copy link
Contributor

fwyzard commented Sep 10, 2014

Given the set of changes, it's unlikely that the error is related to this
PR.

.A

On 10 September 2014 22:37, cmsbuild notifications@github.com wrote:

This pull request is fully signed and it will be integrated in one of the
next CMSSW_7_2_X IBs unless changes (but tests are reportedly failing).


Reply to this email directly or view it on GitHub
#5258 (comment).

@ebouvier ebouvier mentioned this pull request Sep 10, 2014
@Martin-Grunewald
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

nclopezo added a commit that referenced this pull request Sep 11, 2014
HLTrigger/Configuration -- Fine tune adjustments to run2 menu
@nclopezo nclopezo merged commit e05ab55 into cms-sw:CMSSW_7_2_X Sep 11, 2014
@perrotta perrotta deleted the fineTuneAdjustmentsToRun2Menu branch September 11, 2014 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants