Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug on demand offline #5297

Merged
merged 4 commits into from Sep 17, 2014
Merged

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Sep 15, 2014

Bug fix to allow OnDemand not to crash with offline configuration.

No regression expected.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_2_X.

Fix bug on demand offline

It involves the following packages:

RecoLocalTracker/SubCollectionProducers

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Sep 15, 2014

testing

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Sep 15, 2014

+1

for #5297 b2b8e8b
tested in CMSSW_7_2_X_2014-09-15-0200 (test area sign428).
There are not physics or visible timing changes in monitored workflows (fwlite and DQM plots chacked).

The crash reported in https://hypernews.cern.ch/HyperNews/CMS/get/recoTracking/1477/2.html
is fixed. (checked with a cherry-pick in pre5)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

@VinInn
Copy link
Contributor Author

VinInn commented Sep 17, 2014

ping: why not merged yet?

nclopezo added a commit that referenced this pull request Sep 17, 2014
RecoLocalTracker/SubCollectionProducers -- Fix bug on demand offline
@nclopezo nclopezo merged commit fc35041 into cms-sw:CMSSW_7_2_X Sep 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants