Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang fixes for RecoEgamma/ElectronIdentification #5301

Merged
merged 2 commits into from Sep 17, 2014
Merged

Clang fixes for RecoEgamma/ElectronIdentification #5301

merged 2 commits into from Sep 17, 2014

Conversation

Dr15Jones
Copy link
Contributor

Fixed clang compiler warnings.

@Dr15Jones
Removed unused member data
70768b3 
The clang compiler was warning about member data which were never
used.
@Dr15Jones
Silence warning about hiding a virtual function
95eee89 
The clang compiler issued a warning that the declaration of result(...)
hid the version of that function from the base class. As the new
result(...) was being used and therefore was intended to be different from
the base class, issuing a 'using' declaration for the base class function
now silences the warning.
@cmsbuild cmsbuild added this to the Next CMSSW_7_2_X milestone Sep 15, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X.

Clang fixes for RecoEgamma/ElectronIdentification

It involves the following packages:

RecoEgamma/ElectronIdentification

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@StoyanStoynev
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1
Tested at: 95eee89
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5301/956/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5301/956/summary.html

@StoyanStoynev
Copy link
Contributor

+1
Fixes (warning about a proper declaration; unused member data removed).
Signing off for 95eee89 based on jenkins. No diffs, none expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

@cmsbuild cmsbuild mentioned this pull request Sep 17, 2014
Merged
davidlange6 added a commit that referenced this pull request Sep 17, 2014
@davidlange6
Merge pull request #5301 from Dr15Jones/clangFixRecoEgammaElectronIde…
2d0a9f0 
…ntification

Clang fixes for RecoEgamma/ElectronIdentification
@davidlange6 davidlange6 merged commit 2d0a9f0 into cms-sw:CMSSW_7_2_X Sep 17, 2014
@Dr15Jones Dr15Jones deleted the clangFixRecoEgammaElectronIdentification branch September 25, 2014 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed reconstruction-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @StoyanStoynev @davidlange6