Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastTimerServiceClient: update plots after every lumisection #5305

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 15, 2014

Adapt the DQM clients to the 7.2.x DQMEDHarvesting interface, which is necessary to properly update histograms online, and in general when running the DQM harvesting with the "Online" convention.

This should also fix the errors reported by the CLANG builds: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc481/CMSSW_7_2_CLANG_X_2014-09-15-0200/HLTrigger/Timer .

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_2_X.

FastTimerServiceClient: update plots after every lumisection

It involves the following packages:

HLTrigger/Timer

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@fwyzard fwyzard force-pushed the FastTimerServiceClient_update_interface_72x branch from 310e53c to e9bb367 Compare September 15, 2014 22:59
@cmsbuild
Copy link
Contributor

Pull request #5305 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 15, 2014

+1

assuming it doesn't break anything...

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 17, 2014
…nterface_72x

FastTimerServiceClient: update plots after every lumisection
@davidlange6 davidlange6 merged commit d62550c into cms-sw:CMSSW_7_2_X Sep 17, 2014
@fwyzard fwyzard deleted the FastTimerServiceClient_update_interface_72x branch December 23, 2014 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants