Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted MultiTrackSelector from global to stream #5324

Merged
merged 1 commit into from Sep 17, 2014
Merged

Converted MultiTrackSelector from global to stream #5324

merged 1 commit into from Sep 17, 2014

Conversation

Dr15Jones
Copy link
Contributor

Helgrind identified a race condition in MultiTrackSelector. The problem
was StringCutObjectSelector is not const thread safe (i.e. it has a const
function which modifies its internal state) and therefore only one thread
at a time can call it. Therefore MultiTrackSelector can not simultaneously
talk to multiple events which means it can not be a global module. However,
converting the module to a stream module is thread safe.

@Dr15Jones
Converted MultiTrackSelector from global to stream
3bc7855 
Helgrind identified a race condition in MultiTrackSelector. The problem
was StringCutObjectSelector is not const thread safe (i.e. it has a const
function which modifies its internal state) and therefore only one thread
at a time can call it. Therefore MultiTrackSelector can not simultaneously
talk to multiple events. However, converting the module to a stream module
is thread safe.
@cmsbuild cmsbuild added this to the Next CMSSW_7_2_X milestone Sep 16, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X.

Converted MultiTrackSelector from global to stream

It involves the following packages:

RecoTracker/FinalTrackSelectors

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @VinInn, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@VinInn
Copy link
Contributor

VinInn commented Sep 17, 2014

too bad...
+1

@cmsbuild
Copy link
Contributor

+1
Tested at: 3bc7855
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5324/972/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5324/972/summary.html

@StoyanStoynev
Copy link
Contributor

+1
Thread-safety fix.
Signing off for 3bc7855 based on Jenkins. No diffs, none expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 17, 2014
@davidlange6
Merge pull request #5324 from Dr15Jones/makeMultiTrackSelectorStreamM…
0d2717a 
…odule

Converted MultiTrackSelector from global to stream
@davidlange6 davidlange6 merged commit 0d2717a into cms-sw:CMSSW_7_2_X Sep 17, 2014
@Dr15Jones Dr15Jones deleted the makeMultiTrackSelectorStreamModule branch September 25, 2014 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed reconstruction-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_2_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Dr15Jones @cmsbuild @VinInn @StoyanStoynev @davidlange6