Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing comment for JetDeltaRValueMapProducer #5353

Merged

Conversation

rappoccio
Copy link
Contributor

The comment for the file JetDeltaRValueMapProducer.cc is completely copied (wrongly) from another module.
I fixed it to have the correct comment for posterity and to avoid confusion.

(As if anyone but my future self will ever read this file).

http://xkcd.com/1421/

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rappoccio for CMSSW_7_2_X.

Fixing comment for JetDeltaRValueMapProducer

It involves the following packages:

CommonTools/RecoAlgos

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
For d9c8dcd .
This PR changes few lines of commented out text and nothing more. Yet there are some non-trivial differences in the jenkins tests - clearly a problem with the tests themselves. Hopefully this is to be resolved as part of the "irreproducibility" compaign.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 23, 2014
…ent_72x

Fixing comment for JetDeltaRValueMapProducer
@davidlange6 davidlange6 merged commit 92b59d5 into cms-sw:CMSSW_7_2_X Sep 23, 2014
@rappoccio rappoccio deleted the rappoccio_CommonTools_FixComment_72x branch November 3, 2014 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants