Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2 hbhe noise filter clean up #5389

Merged
merged 9 commits into from Sep 22, 2014

Conversation

cmsbuild
Copy link
Contributor

This is the cleanup version of the Run2 HBHE noise filter.

Compared to previous request (request #5123 ), a few changes are done:

  1. Nothing is changed in HLTrigger/Configuration; now used preferred method of existsAs and descriptions
  2. Style change following comments from previous request

Thanks,
Yi Chen

Automatically ported from CMSSW_7_2_X #5168

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_7_3_X.

Run2 hbhe noise filter clean up

It involves the following packages:

CommonTools/RecoAlgos
DataFormats/METReco
HLTrigger/JetMET
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers
RecoMET/METAlgorithms
RecoMET/METProducers

@perrotta, @cmsbuild, @nclopezo, @fwyzard, @Martin-Grunewald, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@nhanvtran, @TaiSakuma, @argiro, @mmarionncern, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@nclopezo
Copy link
Contributor

+1
The version of this PR in 7_2_X passed the jenkins tests.

@Martin-Grunewald
Copy link
Contributor

+1

@slava77
Copy link
Contributor

slava77 commented Sep 19, 2014

Compared to #5168 (comment),
the behavior now appears to be as expected:

  • more entries with flags (QCD dijet no PU sample, matrix 38.0)
    wf38_hcal_hits_rbx
    wf38_hcal_energy_rbx
  • more entries in the cleaned met plots (as I understand, now all the flags are ignored, and the number of entries in this particular plot is the same as the number of processed events; this is ttbar with 25 ns pu matrix 25202.0)
    wf25202_cleaned_met

Timing seems ok (about 20% increase), as an example, ttbar with run 1 pu (matrix 202)

        hcalnoise        4.76537 ms/ev -> 6.05341 ms/ev

@slava77
Copy link
Contributor

slava77 commented Sep 19, 2014

+1

for #5389 11d6443

tested in CMSSW_7_2_X_2014-09-15-0200 (test area sign429)

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Sep 22, 2014

@nclopezo, what happened to the comparison?

ktf added a commit that referenced this pull request Sep 22, 2014
@ktf ktf merged commit 02f4975 into cms-sw:CMSSW_7_3_X Sep 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants