Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use class type_info, rather than class name, for dictionary checking #5399

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Sep 17, 2014

When checking for a class dictionary, use the std::type_info of the class, rather than the name of the class. This makes the checking independent of naming conventions, and also reduces string demangling and other string manipulations.
This pull request also changes the obsolete "gROOT->GetClass()" to the preferred equivalent, "TClass::GetClass()", in the framework.
Please merge this pull request as soon as convenient.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_3_ROOT6_X.

Use class type_info, rather than class name, for dictionary checking

It involves the following packages:

DataFormats/Common
DataFormats/Provenance
FWCore/FWLite
FWCore/Framework
FWCore/RootAutoLibraryLoader
FWCore/Utilities
IOPool/Common
IOPool/Input
IOPool/Output
IOPool/Streamer

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Sep 17, 2014
Use class type_info, rather than class name, for dictionary checking
@davidlt davidlt merged commit 074662a into cms-sw:CMSSW_7_3_ROOT6_X Sep 17, 2014
@wmtan wmtan deleted the UseTypeInfoForDictionaryChecking branch September 26, 2014 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants