Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward port for Online DQM from 71X #5421

Merged
merged 55 commits into from Sep 25, 2014

Conversation

dmitrijus
Copy link
Contributor

This ports all the changes done to packages under:

DQM/*
DQMServices/*
which are not yet in 72X.

I've used some handwritten script to extract the commit ids and
then cherry picked them on top of 72X.

I really don't like this approach,
but I could not think of anything better.

borrello and others added 30 commits September 18, 2014 17:21
(cherry picked from commit f459a20)

Conflicts:
	DQM/Integration/python/test/FrontierCondition_GT_cfi.py
(cherry picked from commit 11e3097)
(cherry picked from commit b7caf09)
(cherry picked from commit 3fd1a8b)
In several cases some lumisections won't appear in our storage,
in such case, we should start processing the next available lumisection.

This commit implements a flag _nextLumiTimeoutMillis_.
If it is set, each missing lumi will start a timer.
After the timer is triggered, and if and only if the next lumi is
available, the source will switch to that lumi.

For example:

1. nextLumiTimeMillis is set to 45000
2. we see files ls0001 ls0002 ls0005
3. source processes ls 1 and 2
4. 45 seconds pass
5. source skips 3..4, and starts processing ls0005

This commit also changes how EoR files work: instead of relying on EoR
content, the source uses the highest *seen* lumi as the number of lumis.
This is compatible with our code in offline and online (where EoR are,
for now, empty).

(cherry picked from commit a14c0f8)
(cherry picked from commit b0151bb)
(cherry picked from commit 96a657d)

Conflicts:
	DQM/Integration/python/test/FrontierCondition_GT_cfi.py
Implement a python script which will rename/delete/sendemail after
the disk usage on the ramdisk exceeds the specified threshold.

(cherry picked from commit f49d061)
(cherry picked from commit 92abd55)
(cherry picked from commit 5980410)
(cherry picked from commit 0839b52)
(cherry picked from commit 40c574a)
…ing whether or not it is nullptr; if so, store PB files in FU mode only for non-empty lumisections.

(cherry picked from commit b7d7d12)
…ting permissions to 0666.

(cherry picked from commit be059a9)
…files merged and encoded with ProtolBuffer.

(cherry picked from commit 41396fc)
…ting permissions to 0664.

(cherry picked from commit fe3fae1)
…d with ProtocolBuffer.

(cherry picked from commit 03aa9c4)
Also:
Separate edm and dqm namespaces, and make them explicit where needed.

(cherry picked from commit 05ed6ce)

Conflicts:
	DQMServices/StreamerIO/plugins/DQMProtobufReader.h
	DQMServices/StreamerIO/plugins/DQMStreamerReader.h
Now includes a startup script.

(cherry picked from commit 9e26670)
(cherry picked from commit e5b1fe9)
lumiScalers collection size.

(cherry picked from commit fc00421)
…Reader).

Also implement a way to load json files which use unexpected 'data'
field format in DQMProtobufReader.

(cherry picked from commit fc0dbea)
@deguio
Copy link
Contributor

deguio commented Sep 25, 2014

@emeschi, @mommsen could you please have a look at this PR and approve? this is the port of the changes we merged in 71 in the last months. this is needed to align the two releases cycles.
thanks in advance,
F.

@emeschi
Copy link
Contributor

emeschi commented Sep 25, 2014

+1

Not sure why DAQ is involved since these are changes to DQM* only ????

On 25 Sep 2014, at 19:07, deguio <notifications@github.commailto:notifications@github.com> wrote:

@emeschihttps://github.com/emeschi, @mommsenhttps://github.com/mommsen could you please have a look at this PR and approve? this is the port of the changes we merged in 71 in the last months. this is needed to align the two releases cycles.
thanks in advance,
F.


Reply to this email directly or view it on GitHubhttps://github.com//pull/5421#issuecomment-56850685.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Sep 25, 2014

@emeschi EventFilter/Utilities is touched by this PR.

@emeschi
Copy link
Contributor

emeschi commented Sep 25, 2014

Ok I see. So this should be tagged as forward port not only of DQM from 71X but also of #5237
Anyway it looks ok to me so fine.

On 25 Sep 2014, at 19:43, Giulio Eulisse <notifications@github.commailto:notifications@github.com> wrote:

@emeschihttps://github.com/emeschi EventFilter/Utilities is touched by this PR.


Reply to this email directly or view it on GitHubhttps://github.com//pull/5421#issuecomment-56855888.

davidlange6 added a commit that referenced this pull request Sep 25, 2014
Forward port for Online DQM from 71X
@davidlange6 davidlange6 merged commit b35aa55 into cms-sw:CMSSW_7_2_X Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet