TCDS readout for 7_1_X

[smorovic]

Code to support reading event information from TCDS FED 1024 in the FRD input source

[cmsbuild]

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_1_X.

TCDS readout for 7_1_X

It involves the following packages:

EventFilter/FEDInterface
EventFilter/Utilities

@mommsen, @cmsbuild, @nclopezo, @emeschi can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[emeschi]

+1
On 19 Sep 2014, at 11:47, cmsbuild <notifications@github.commailto:notifications@github.com> wrote:

A new Pull Request was created by @smorovichttps://github.com/smorovic (Srecko Morovic) for CMSSW_7_1_X.

TCDS readout for 7_1_X

It involves the following packages:

EventFilter/FEDInterface
EventFilter/Utilities

@mommsenhttps://github.com/mommsen, @cmsbuildhttps://github.com/cmsbuild, @nclopezohttps://github.com/nclopezo, @emeschihttps://github.com/emeschi can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@deganohttps://github.com/degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5433#issuecomment-56157579.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it?

[fwyzard]

could you drop this cout ?

[emeschi]

Yes, my bad. Srecko could you do that and update ?
Thanks,
E.

On 19 Sep 2014, at 12:01, Andrea Bocci <notifications@github.commailto:notifications@github.com> wrote:

In EventFilter/Utilities/plugins/FRDStreamSource.cchttp://FRDStreamSource.cc:

@@ -26,6 +27,7 @@ FRDStreamSource::FRDStreamSource(edm::ParameterSet const& pset,

bool FRDStreamSource::setRunAndEventInfo(edm::EventID& id, edm::TimeValue_t& theTime)
{

• std::cout <<"This is the event id now " << id << std::endl;

could you drop this cout ?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5433/files#r17777339.

[emeschi]

Although this source is for testing purposes only and not used in production
E.

On 19 Sep 2014, at 12:01, Andrea Bocci <notifications@github.commailto:notifications@github.com> wrote:

In EventFilter/Utilities/plugins/FRDStreamSource.cchttp://FRDStreamSource.cc:

@@ -26,6 +27,7 @@ FRDStreamSource::FRDStreamSource(edm::ParameterSet const& pset,

bool FRDStreamSource::setRunAndEventInfo(edm::EventID& id, edm::TimeValue_t& theTime)
{

• std::cout <<"This is the event id now " << id << std::endl;

could you drop this cout ?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5433/files#r17777339.

[cmsbuild]

Pull request #5433 was updated. @mommsen, @cmsbuild, @nclopezo, @emeschi can you please check and sign again.

[emeschi]

+1
On 19 Sep 2014, at 12:44, cmsbuild <notifications@github.commailto:notifications@github.com> wrote:

Pull request #5433#5433 was updated. @mommsenhttps://github.com/mommsen, @cmsbuildhttps://github.com/cmsbuild, @nclopezohttps://github.com/nclopezo, @emeschihttps://github.com/emeschi can you please check and sign again.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5433#issuecomment-56162264.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it?

[cmsbuild]

+1
Tested at: dc145a7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5433/1952/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5433/1952/summary.html