Changed generic 'action' names to be more descriptive. #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptive names exception_actions and ExceptionToActionTable.
|
The following categories have been signed by chrjones (a.k.a. @Dr15Jones on GitHub): Core @cms-git-visualization, @cms-git-core, @cms-git-geometry |
|
@nclopezo please test. |
ghost
assigned 
|
Hi, I took this changes on to of CMSSW_7_0_X_2013-08-16-0200, and when I tried to build I got the following error: In file included from /build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/Mixing/Base/src/PileUp.cc:20:0:
/build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/Mixing/Base/src/SecondaryEventProvider.h:20:14: error: 'ActionTable' has not been declared
/build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/Mixing/Base/src/PileUp.cc: In constructor 'edm::PileUp::PileUp(const edm::ParameterSet&, double, TH1F*, bool)':
/build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/Mixing/Base/src/PileUp.cc:64:92: error: 'ActionTable' was not declared in this scope
In file included from /build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/Mixing/Base/src/SecondaryEventProvider.cc:1:0:
/build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/Mixing/Base/src/SecondaryEventProvider.h:20:14: error: 'ActionTable' has not been declared
/build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/Mixing/Base/src/SecondaryEventProvider.cc:9:22: error: 'ActionTable' has not been declared
/build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/Mixing/Base/src/SecondaryEventProvider.cc: In constructor 'edm::SecondaryEventProvider::SecondaryEventProvider(std::vector&, edm::ProductRegistry&, const int&, boost::shared_ptr)':
/build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/Mixing/Base/src/SecondaryEventProvider.cc:11:86: error: no matching function for call to 'edm::WorkerManager::WorkerManager(boost::shared_ptr, const int&)'
/build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/Mixing/Base/src/SecondaryEventProvider.cc:11:86: note: candidate is:
In file included from /build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/Mixing/Base/src/SecondaryEventProvider.h:4:0,
from /build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/Mixing/Base/src/SecondaryEventProvider.cc:1:
/build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/FWCore/Framework/interface/WorkerManager.h:31:5: note: edm::WorkerManager::WorkerManager(boost::shared_ptr, const edm::ExceptionToActionTable&)
/build/dmendezl/CMSSW_7_0_X_2013-08-16-0200/src/FWCore/Framework/interface/WorkerManager.h:31:5: note: no known conversion for argument 2 from 'const int' to 'const edm::ExceptionToActionTable&'
you can see the complete logs here: |
|
The recent commit fixes the compilation problem found by David. Please retest. |
|
Did compile. Bypassing signatures. |
ktf
added a commit
that referenced
this pull request
Aug 16, 2013
Changed generic 'action' names to be more descriptive.
nclopezo
pushed a commit
to nclopezo/cmssw
that referenced
this pull request
Apr 30, 2014
Add data for CondFormats/JetMETObjects to github repository.
gpetruc
added a commit
to gpetruc/cmssw
that referenced
this pull request
Jan 4, 2016
Heppy: adding rl_* control variables (only MT2 related)
arizzi
added a commit
to arizzi/cmssw
that referenced
this pull request
Sep 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the generic name actions:: and ActionTable to the more descriptive names exception_actions and ExceptionToActionTable.