Removed use of ConstProductRegistry since the function is deprecated #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…being removed from the framework. The code was attempting to lookup a value for a ParameterSet for another module via the ConstProductRegistry. The particular function being called will be going away for thread safety reasons. The code was changes to instead use the ProcessHistory at beginRun to lookup the same information. This is actually superior since the ConstProductRegistry call could have caused an exception if different jobs were using different configurations for the module being searched. In addition to the above I removed unused member data, fixed an end of job memory leak and added a 'fillDescriptions' to properly handle the case where a tracked parameter was allowed to not be specified.
|
@nclopezo please test. |
ghost
assigned 
|
Hi, I took these changes on top of CMSSW_7_0_X_2013-08-16-0200, I ran the unit tests and RelVals, all tests passed. |
ktf
added a commit
that referenced
this pull request
Aug 16, 2013
Removed use of ConstProductRegistry since the function is deprecated
nclopezo
pushed a commit
to nclopezo/cmssw
that referenced
this pull request
Apr 30, 2014
updated config tag to V05-01-20
arizzi
added a commit
to arizzi/cmssw
that referenced
this pull request
Sep 8, 2016
add missing Znn samples
cmsbuild
pushed a commit
that referenced
this pull request
Sep 9, 2020
If the Status_OnGPU path exists already, replace its contente instead of recreating it. This guarantuees that the order of the paths in the menu and monitor toold does not change.
cmsbuild
pushed a commit
that referenced
this pull request
Sep 24, 2020
If the Status_OnGPU path exists already, replace its contente instead of recreating it. This guarantuees that the order of the paths in the menu and monitor toold does not change.
fwyzard
added a commit
to fwyzard/cmssw
that referenced
this pull request
Dec 16, 2020
If the Status_OnGPU path exists already, replace its contente instead of recreating it. This guarantuees that the order of the paths in the menu and monitor toold does not change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was attempting to lookup a value for a ParameterSet for another module via the ConstProductRegistry.
The particular function being called will be going away for thread safety reasons. The code was changes to
instead use the ProcessHistory at beginRun to lookup the same information. This is actually superior since
the ConstProductRegistry call could have caused an exception if different jobs were using different configurations
for the module being searched.
In addition to the above I removed unused member data, fixed an end of job memory leak and added a
'fillDescriptions' to properly handle the case where a tracked parameter was allowed to not be specified.