Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking getByToken migration, part 0.1 (DeDx, IterativeTracking, FinalTrackSelectors) #552

Closed

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Aug 16, 2013

getByToken migration in many tracking modules.

First set of tags, with no external dependencies

Notes:

  • some modules not running in the default sequence have not been migrated
  • the getByLabels done through the ClusterRemovalRefSetter have not been migrated, as to my knowledge they're obsolete, and they're not trivial to do (the tag is known only at runtime). A call to consumesMany might be added if those are needed.

@ghost ghost assigned nclopezo Aug 16, 2013
@ktf
Copy link
Contributor

ktf commented Aug 16, 2013

@nclopezo can you please test?
@slava77 @thspeer can you sign off? Thanks.

@cmsbuild
Copy link
Contributor

The following categories have been rejected by speer (a.k.a. @thspeer on GitHub): Reconstruction

@cms-git-reconstruction

@thspeer
Copy link
Contributor

thspeer commented Aug 19, 2013

Since Pull Request 556 is OK and contains this as well, I signed only PR 556

@ktf
Copy link
Contributor

ktf commented Aug 19, 2013

Please use hash in front of the pull request id (e.g. #556) to mention other pull requests given github is smart enough to cross-link those, then. Closing this one.

@ktf ktf closed this Aug 19, 2013
nclopezo pushed a commit to nclopezo/cmssw that referenced this pull request Apr 30, 2014
@gpetruc gpetruc deleted the tracking-getByToken-part0.1 branch September 30, 2015 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants