Strip cluster shape filter with subcluster info #5583
Conversation
|
A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_3_X. Strip cluster shape filter with subcluster info It involves the following packages: RecoPixelVertexing/PixelLowPtUtilities @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
…,detachedTriplet). Switching on SeedFilter for pixelLess, tobTec
gpetruc
force-pushed
the
simpleStripSubClusterFilter-from72X
branch
from
9464288
to
af5162f
Compare
|
sorry for the extra commit, I had realized that I had forgotten to git add a fix to a typo in one of the python files. |
|
Pull request #5583 was updated. @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please check and sign again. |
| const TrackingRecHit* hit = thit->hit(); | ||
| if (hit == 0 || !hit->isValid()) return true; | ||
| if (hit->geographicalId().subdetId() <= 2) return true; // we look only at strips for now | ||
| return testLastHit(hit, tsos, false); |
There was a problem hiding this comment.
The code in this function is mostly repeated four times (in this file). Can't you template it or anyway modularize it better?
| const StripGeomDetUnit* stripDetUnit = dynamic_cast<const StripGeomDetUnit *>(det); | ||
| if (det == 0) { edm::LogError("Strip not a StripGeomDetUnit?") << " on " << detId.rawId() << "\n"; return true; } | ||
|
|
||
| float MeVperADCStrip = 3.61e-06*265; |
There was a problem hiding this comment.
Another small point - leave a comment here about the intention; no idea why the 265 - I suppose it has nothing to do with the other "magic" number used (twice!) above, namely the 254. Generally - make constants, don't use numbers inside logical expressions, leave a comment.
|
@cmsbuild tests? comparison? |
|
I am showing some results below based on wf 202 (ttbar + PU) and wf 38 (flat pt QCD). I checked other wf too but generally there is nothing to report from them. An exception seems to be HI RECO - it fails in wf 140.51 (RunHI2010), I should check with others HI wf too before investigating: Back to wf 202, overall significant changes to seed multiplicity in iterations 5 and 6 (mostly), average layers/hits per tracks go slightly down, fake rate goes down. From higher level objects only b-tagging performance show some deviation (depending on the discriminant). This PR is in red below (black is CMSSW_7_3_X_2014-09-24-1400)
Track efficiency vs vertex position changes in tails (this is wf 38.0):
B-tagging (from wf 202.0):
|
|
+1 |
|
The static analyzer run on this pull request shows a number of problems https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5583/111/llvm-analysis/ |
|
@Dr15Jones What is included in the reports - all the dependent sources? Many of the files reported are not touched at all in this PR. |
|
Yes, everything that had to be recompiled gets scanned by the static analyzer (since the static analyzer works just like a compiler). |
|
As far as I see none of the reports is related to this PR. |
…m72X Strip cluster shape filter with subcluster info
Introduce a new strip cluster shape filter:
Presented at the tracking POG meeting on 22 Sep 2014, https://indico.cern.ch/event/337840/
After the meeting, it was verified that it doesn't have ill effects on the QCD 3TeV relval, and that the small inefficiency introduced in the pixelLess and tobTec does not depend on the transverse impact parameter of the tracks.