AK5 to AK4, re-redux #5588

rappoccio · 2014-09-26T16:41:56Z

Rebasing PR #5350.

Switches AK5 to AK4, including all of the changes from @arizzi, @vadler and others. Will break the relvals until the latest GT PR is merged as well.

…ng to fix various runtests by setting the GT to run2_mc

…ies runtest. Also fixing a couple of stray AK5s from python files more than one layer deep in the package

cmsbuild · 2014-09-26T16:42:56Z

A new Pull Request was created by @rappoccio for CMSSW_7_2_X.

AK5 to AK4, re-redux

It involves the following packages:

CommonTools/ParticleFlow
DQM/Physics
DQMOffline/JetMET
DQMOffline/RecoB
FastSimulation/ParticleFlow
JetMETCorrections/Configuration
JetMETCorrections/Modules
JetMETCorrections/Type1MET
PhysicsTools/PatAlgos
RecoJets/JetProducers
RecoTauTag/Configuration
TopQuarkAnalysis/Configuration
TopQuarkAnalysis/TopJetCombination
TopQuarkAnalysis/TopObjectResolutions
Validation/RecoJets
Validation/RecoParticleFlow

@civanch, @nclopezo, @StoyanStoynev, @lveldere, @danduggan, @mdhildreth, @monttj, @cmsbuild, @rovere, @deguio, @slava77, @vadler, @ojeda can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @yslai, @acaudron, @jpavel, @mmarionncern, @nhanvtran, @schoef, @ferencek, @pvmulder, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

slava77 · 2014-09-27T03:47:06Z

Hi Sal,

Does the "latest GT PR " exist already?

davidlange6 · 2014-09-27T06:37:50Z

Not yet - was hoped for yesterday

On Sep 27, 2014, at 5:47 AM, Slava Krutelyov notifications@github.com
wrote:

Hi Sal,

Does the "latest GT PR " exist already?

—
Reply to this email directly or view it on GitHub.

cmsbuild · 2014-09-27T10:23:36Z

-1
Tested at: e80ed32
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 27-Sep-2014 12:06:01 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1
   [1] Calling beginRun for unscheduled module EventSetupRecordDataGetter/'hltGetConditions'
   [2] Using EventSetup component JetCorrectionESChain/'ak4PFCHSL1FastL2L3' to make data JetCorrector/'ak4PFCHSL1FastL2L3' in record JetCorrectionsRecord
   [3] Using EventSetup component L1FastjetCorrectionESProducer/'ak4PFCHSL1Fastjet' to make data JetCorrector/'ak4PFCHSL1Fastjet' in record JetCorrectionsRecord
Exception Message:
No data of type "JetCorrectorParametersCollection" with label "AK4PFchs" in record "JetCorrectionsRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID/step2_SingleMuPt10+SingleMuPt10FSIdINPUT+SingleMuPt10FS_ID.log
----- Begin Fatal Exception 27-Sep-2014 12:12:34 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1
   [1] Calling beginRun for unscheduled module EventSetupRecordDataGetter/'hltGetConditions'
   [2] Using EventSetup component JetCorrectionESChain/'ak4PFCHSL1FastL2L3' to make data JetCorrector/'ak4PFCHSL1FastL2L3' in record JetCorrectionsRecord
   [3] Using EventSetup component L1FastjetCorrectionESProducer/'ak4PFCHSL1Fastjet' to make data JetCorrector/'ak4PFCHSL1Fastjet' in record JetCorrectionsRecord
Exception Message:
No data of type "JetCorrectorParametersCollection" with label "AK4PFchs" in record "JetCorrectionsRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 27-Sep-2014 12:14:58 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'dqmoffline_step'
   [2] Calling event method for module JetAnalyzer/'jetDQMAnalyzerAk4PFUncleaned'
   [3] Using EventSetup component JetCorrectionESChain/'ak4PFL1FastL2L3' to make data JetCorrector/'ak4PFL1FastL2L3' in record JetCorrectionsRecord
   [4] Using EventSetup component L1FastjetCorrectionESProducer/'ak4PFL1Fastjet' to make data JetCorrector/'ak4PFL1Fastjet' in record JetCorrectionsRecord
Exception Message:
No data of type "JetCorrectorParametersCollection" with label "AK4PF" in record "JetCorrectionsRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 27-Sep-2014 12:15:26 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'dqmoffline_step'
   [2] Calling event method for module JetAnalyzer/'jetDQMAnalyzerAk4PFUncleaned'
   [3] Using EventSetup component JetCorrectionESChain/'ak4PFL1FastL2L3' to make data JetCorrector/'ak4PFL1FastL2L3' in record JetCorrectionsRecord
   [4] Using EventSetup component L1FastjetCorrectionESProducer/'ak4PFL1Fastjet' to make data JetCorrector/'ak4PFL1Fastjet' in record JetCorrectionsRecord
Exception Message:
No data of type "JetCorrectorParametersCollection" with label "AK4PF" in record "JetCorrectionsRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5588/1087/summary.html

diguida · 2014-10-03T09:54:10Z

@vadler @rappoccio
4.71 works with diguida@b041bf1 on top of this PR. Now launching the short matrix.

diguida · 2014-10-03T09:57:57Z

@nclopezo
Can you please re-run the tests with this PR + #5662
Thanks

davidlange6 · 2014-10-03T10:00:18Z

please instead update this PR to include 5662 on which it depends

On Oct 3, 2014, at 11:57 AM, Salvatore Di Guida notifications@github.com
wrote:

@nclopezo
Can you please re-run the tests with this PR + #5662
Thanks

—
Reply to this email directly or view it on GitHub.

diguida · 2014-10-03T10:04:36Z

@davidlange6
I have rebased everything in one branch. I can send a new PR, and close the other one. Is this ok?

diguida · 2014-10-03T10:09:05Z

In the meantime, the short matrix test on my local machine are ok:

4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Oct  3 11:58:04 2014-date Fri Oct  3 11:54:55 2014; exit: 0 0 0 0 0
4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Fri Oct  3 12:08:16 2014-date Fri Oct  3 11:54:59 2014; exit: 0 0 0 0
5.1_TTbar+TTbarFS+HARVESTFS Step0-PASSED Step1-PASSED  - time date Fri Oct  3 11:57:16 2014-date Fri Oct  3 11:55:02 2014; exit: 0 0
8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Oct  3 11:58:40 2014-date Fri Oct  3 11:55:05 2014; exit: 0 0 0 0 0
25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Oct  3 12:08:26 2014-date Fri Oct  3 11:57:26 2014; exit: 0 0 0 0 0
1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Oct  3 12:04:57 2014-date Fri Oct  3 11:58:08 2014; exit: 0 0 0 0 0
1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Fri Oct  3 12:03:21 2014-date Fri Oct  3 11:58:42 2014; exit: 0 0 0 0
7 7 6 6 4 tests passed, 0 0 0 0 0 failed

davidlange6 · 2014-10-03T10:13:29Z

i leave it to you and Sal to decide how best to make a working PR.

On Oct 3, 2014, at 12:04 PM, Salvatore Di Guida notifications@github.com
wrote:

@davidlange6
I have rebased everything in one branch. I can send a new PR, and close the other one. Is this ok?

—
Reply to this email directly or view it on GitHub.

diguida · 2014-10-03T10:18:46Z

@davidlange6
New PR created: #5666

rappoccio · 2014-10-03T13:52:26Z

OK, so should this one be closed?

Cheers,
Sal

diguida · 2014-10-03T17:17:30Z

Let's close it, we can follow the developments in the other one.

diguida · 2014-10-03T17:18:19Z

Or you can cherry-pick my changes here, so tests will be re-run anyway.

deguio · 2014-10-06T09:45:45Z

-1
superseded by #5666

rappoccio added 7 commits September 26, 2014 18:07

Adding AK5 to AK4 transition again, from scratch

09c6c59

Removing the accidentally-added HLTrigger/HLTAnalyzers, and also tryi…

0325cb8

…ng to fix various runtests by setting the GT to run2_mc

Reverting HLTanalyzers correctly

7c0fc7e

Removing running on L2L3Residuals when using MC for the metUncertaint…

5ca5d1c

…ies runtest. Also fixing a couple of stray AK5s from python files more than one layer deep in the package

Adding some DQM modules to point at the right JEC ES Producers

d746204

Changing CHS to chs when accessing PFCHS payloads

fee15e6

Forgot a few CHS->chs changes

e80ed32

rappoccio mentioned this pull request Sep 26, 2014

AK5 to AK4 for JEC's, Redux #5350

Closed

cmsbuild added this to the Next CMSSW_7_2_X milestone Sep 26, 2014

cmsbuild added analysis-pending comparison-pending dqm-pending fastsim-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 26, 2014

cmsbuild added analysis-pending and removed analysis-pending comparison-pending dqm-pending fastsim-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 27, 2014

diguida mentioned this pull request Oct 3, 2014

AK5 to AK4 migration with new Global Tags #5666

Merged

nclopezo closed this Oct 6, 2014

rappoccio deleted the AK5toAK4_72x_rebase branch November 3, 2014 21:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AK5 to AK4, re-redux #5588

AK5 to AK4, re-redux #5588

rappoccio commented Sep 26, 2014

cmsbuild commented Sep 26, 2014

slava77 commented Sep 27, 2014

davidlange6 commented Sep 27, 2014

cmsbuild commented Sep 27, 2014

diguida commented Oct 3, 2014

diguida commented Oct 3, 2014

davidlange6 commented Oct 3, 2014

diguida commented Oct 3, 2014

diguida commented Oct 3, 2014

davidlange6 commented Oct 3, 2014

diguida commented Oct 3, 2014

rappoccio commented Oct 3, 2014

diguida commented Oct 3, 2014

diguida commented Oct 3, 2014

deguio commented Oct 6, 2014

AK5 to AK4, re-redux #5588

AK5 to AK4, re-redux #5588

Conversation

rappoccio commented Sep 26, 2014

cmsbuild commented Sep 26, 2014

slava77 commented Sep 27, 2014

davidlange6 commented Sep 27, 2014

cmsbuild commented Sep 27, 2014

diguida commented Oct 3, 2014

diguida commented Oct 3, 2014

davidlange6 commented Oct 3, 2014

diguida commented Oct 3, 2014

diguida commented Oct 3, 2014

davidlange6 commented Oct 3, 2014

diguida commented Oct 3, 2014

rappoccio commented Oct 3, 2014

diguida commented Oct 3, 2014

diguida commented Oct 3, 2014

deguio commented Oct 6, 2014