Fixed problem of extra artifitial tail in ECAL/HCAL

[civanch]

Fix of tail in several HCAL distributions several validation.

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_3_X.

Fixed problem of extra artifitial tail in ECAL/HCAL

It involves the following packages:

SimG4Core/Generators

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[makortel]

Hi Vladimir,

I'm asking mostly out of curiosity, since the fix seems to be related to the 720pre5 "tau bug", which also had an effect in my MT replay tests. So the increase of status code by 1000 (or arbitrary large-enough number) is needed in the end?

Personally I (still) don't like that an existing EDM data product (edm::HepMCProduct via HepMC::GenParticle and HepMC::GenEvent) is modified (although now it would be modified back to original).

[davidlange6]

Not to worry - its being fixed… (later we can find a physically correct and performant solution)

On Oct 1, 2014, at 5:42 PM, Matti Kortelainen notifications@github.com
wrote:

Hi Vladimir,

I'm asking mostly out of curiosity, since the fix seems to be related to the 720pre5 "tau bug", which also had an effect in my MT replay tests. So the increase of status code by 1000 (or arbitrary large-enough number) is needed in the end?

Personally I (still) don't like that an existing EDM data product (edm::HepMCProduct via HepMC::GenParticle and HepMC::GenEvent) is modified (although now it would be modified back to original).

—
Reply to this email directly or view it on GitHub.

[makortel]

Ah, ok, thanks for the information.

[cmsbuild]

+1
Tested at: 9201fb3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5635/129/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5635/129/summary.html

[civanch]

Synchronized with PR #5698.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

[civanch]

I believe that the problem 25202.0 step3 is not connected with this PR but with das or similar. Would it be possible to rerun?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5635/178/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

[cmsbuild]

+1
Tested at: d85b9dc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5635/198/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5635/198/summary.html