ThroughputService: use std::chrono::steady_clock instead of clock_gettime(CLOCK_MONOTONIC, ...) #5645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time(CLOCK_MONOTONIC, ...)
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_3_X. ThroughputService: use std::chrono::steady_clock instead of clock_gettime(CLOCK_MONOTONIC, ...) It involves the following packages: HLTrigger/Timer @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks. |
|
+1 |
cmsbuild
added
comparison-pending
fully-signed
hlt-approved
tests-pending
and removed
comparison-pending
hlt-pending
pending-signatures
tests-pending
labels
ktf
added a commit
that referenced
this pull request
Oct 2, 2014
ThroughputService: use std::chrono::steady_clock instead of clock_gettime(CLOCK_MONOTONIC, ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the ThroughputService on OS X, where clock_gettime is not implemented
According to testChrono,
steady_clock::now()is marginally slower than(CLOCK_MONOTONIC, ...), but in this case the difference should be negligible.