-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport a few clang fixes #5674
Conversation
A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_3_X. Backport a few clang fixes It involves the following packages: DQM/CSCMonitorModule @nclopezo, @StoyanStoynev, @danduggan, @rovere, @cmsbuild, @deguio, @slava77, @ojeda can you please review it and eventually sign? Thanks. |
@cmsbuild test |
-1 >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfBetheHeitlerUpdator.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfChi2MeasurementEstimator.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfCombinedMaterialEffectsUpdator.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfConstraintAtVertex.cc /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfBetheHeitlerUpdator.cc: In member function 'virtual void GsfBetheHeitlerUpdator::compute(const TrajectoryStateOnSurface&, PropagationDirection, GsfMaterialEffectsUpdator::Effect*) const': /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfBetheHeitlerUpdator.cc:129:40: error: no matching function for call to 'Triplet::Triplet(const int&)' GSContainer mixture(theNrComponents); ^ /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfBetheHeitlerUpdator.cc:129:40: note: candidates are: In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/interface/GsfBetheHeitlerUpdator.h:11:0, from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfBetheHeitlerUpdator.cc:1: you can see the results of the tests here: |
seems like clang fixes are turning into a saga, together with #5465 |
- These have been introduced recently. C++14 cannot come early enough.
e85d265
to
8eb5661
Compare
@ktf I have no comments on the code and jenkins are fine. For RECO this is enough here but there is a pending question by Chris. |
@Dr15Jones do you have objections to the answer above? |
I'm not a fan but I'm not going to object. |
+1 |
Ping @deguio @danduggan |
+1 |
This is a smaller subset of clang related fixes. Should merge better than the larger chunk.