Backport a few clang fixes

[ktf]

This is a smaller subset of clang related fixes. Should merge better than the larger chunk.

[cmsbuild]

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_3_X.

Backport a few clang fixes

It involves the following packages:

DQM/CSCMonitorModule
DQMOffline/PFTau
EventFilter/CSCRawToDigi
RecoEcal/EgammaClusterAlgos
RecoEgamma/EgammaIsolationAlgos
RecoLocalCalo/EcalRecAlgos
RecoPixelVertexing/PixelTriplets
RecoTracker/FinalTrackSelectors
RecoTracker/TkSeedGenerator
TrackingTools/GsfTracking

@nclopezo, @StoyanStoynev, @danduggan, @rovere, @cmsbuild, @deguio, @slava77, @ojeda can you please review it and eventually sign? Thanks.
@ghellwig, @barvic, @makortel, @GiacomoSguazzoni, @rovere, @lgray, @bellan, @VinInn, @gpetruc, @cerati, @argiro, @rociovilar, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[StoyanStoynev]

@cmsbuild test

[cmsbuild]

-1
Tested at: e85d265
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfBetheHeitlerUpdator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfChi2MeasurementEstimator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfCombinedMaterialEffectsUpdator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfConstraintAtVertex.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfBetheHeitlerUpdator.cc: In member function 'virtual void GsfBetheHeitlerUpdator::compute(const TrajectoryStateOnSurface&, PropagationDirection, GsfMaterialEffectsUpdator::Effect*) const':
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfBetheHeitlerUpdator.cc:129:40: error: no matching function for call to 'Triplet::Triplet(const int&)'
     GSContainer mixture(theNrComponents);
                                        ^
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfBetheHeitlerUpdator.cc:129:40: note: candidates are:
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/interface/GsfBetheHeitlerUpdator.h:11:0,
                 from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-10-04-0200/src/TrackingTools/GsfTracking/src/GsfBetheHeitlerUpdator.cc:1:


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5674/153/summary.html

[slava77]

seems like clang fixes are turning into a saga, together with #5465

[cmsbuild]

+1
Tested at: 8eb5661
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5674/123/summary.html

[StoyanStoynev]

@ktf I have no comments on the code and jenkins are fine. For RECO this is enough here but there is a pending question by Chris.

[StoyanStoynev]

@Dr15Jones do you have objections to the answer above?

[Dr15Jones]

I'm not a fan but I'm not going to object.

[StoyanStoynev]

+1
For 8eb5661 .
Based on jenkins - no diffs, none expected.

[ktf]

Ping @deguio @danduggan

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?