Use compiler, not introspection, to find nested typedefs #5691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_3_X. Use compiler, not introspection, to find nested typedefs It involves the following packages: DataFormats/Common @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
cmsbuild
removed
comparison-pending
core-pending
pending-signatures
tests-pending
labels
cmsbuild
added
comparison-pending
core-approved
fully-signed
tests-approved
and removed
comparison-pending
core-approved
fully-signed
tests-pending
labels
davidlange6
added a commit
that referenced
this pull request
Oct 5, 2014
Use compiler, not introspection, to find nested typedefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the compiler, rather than introspection, to find the type corresponding to T::value_type or T::member_type for any Wrapper.
In ROOT 6 this avoids unnecessary header autoparsing, and thereby saves memory. Since there is nothing specific to ROOT 6 about this change, for code commonality this change is being made in the main 7_3_X branch.
I ran the full relval matrix, and no new errors occurred.