Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Postfix In AdaptiveVertexFit Sorting #5754

Merged

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Oct 9, 2014

Fix postfix in AdaptiveVertexFit sorting

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2014

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_3_X.

Fix Postfix In AdaptiveVertexFit Sorting

It involves the following packages:

RecoVertex/AdaptiveVertexFit

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@imarches, @makortel, @acaudron, @GiacomoSguazzoni, @rovere, @ferencek, @cerati, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 9, 2014

I will check if reproducibility is restored and then sign.
(tests are running)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2014

@slava77
Copy link
Contributor

slava77 commented Oct 9, 2014

+1

for #5754 b5b1521

checked with a mix of #5687 to confirm that with this change added to both the baseline and the new code, the result is identical, at least based on the histogram level monitoring in DQM/fwlite

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants