Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of a parameter in HLTMuonTrkFilter to cut on absEta #5767

Merged
merged 3 commits into from Oct 10, 2014
Merged

Addition of a parameter in HLTMuonTrkFilter to cut on absEta #5767

merged 3 commits into from Oct 10, 2014

Conversation

HuguesBrun
Copy link
Contributor

This parameter permits to cut on the AbsEta of the trackers muon at HLT

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Oct 9, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2014

A new Pull Request was created by @HuguesBrun (Hugues BRUN) for CMSSW_7_3_X.

Addition of a parameter in HLTMuonTrkFilter to cut on absEta

It involves the following packages:

HLTrigger/Muon

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@abbiendi, @trocino, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

Martin-Grunewald
Martin-Grunewald reviewed Oct 10, 2014
View reviewed changes
HLTrigger/Muon/src/HLTMuonTrkFilter.cc
@@ -82,6 +84,7 @@ HLTMuonTrkFilter::hltFilter(edm::Event& iEvent, const edm::EventSetup& iSetup, t
}
if ( muon.isTrackerMuon() && !muon::isGoodMuon(muon,m_trkMuonId) ) continue;
if ( muon.pt() < m_minPt ) continue;
if ( fabs(muon.eta()) > m_maxAbsEta ) continue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be std::abs instead of fabs!

@Martin-Grunewald
Copy link
Contributor

Also, make a PR for 72X.

@Martin-Grunewald
Copy link
Contributor

-1

@cmsbuild
Copy link
Contributor

Pull request #5767 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please check and sign again.

@HuguesBrun
Copy link
Contributor Author

Hello,
I fixed this PR and sent the PR to backport it in 72X (PR #5768)
Thank you

@cmsbuild
Copy link
Contributor

+1
Tested at: 0e4fe9b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5767/14/summary.html

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 10, 2014
@nclopezo
Merge pull request #5767 from HuguesBrun/addMaxAbsEtaInHLTMuonTrkFilter
d2f441a 
HLTrigger/Muon -- Addition of a parameter in HLTMuonTrkFilter to cut on absEta
@nclopezo nclopezo merged commit d2f441a into cms-sw:CMSSW_7_3_X Oct 10, 2014
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5767/14/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed hlt-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HuguesBrun @cmsbuild @Martin-Grunewald @nclopezo