Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport PR#5767 in CMSSW_7_2_X (Addition of a parameter in HLTMuonTrkFilter to cut on absEta) #5768

Merged

Conversation

HuguesBrun
Copy link
Contributor

This parameter permits to cut on the AbsEta of the trackers muon at HLT

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @HuguesBrun (Hugues BRUN) for CMSSW_7_2_X.

backport PR#5767 in CMSSW_7_2_X (Addition of a parameter in HLTMuonTrkFilter to cut on absEta)

It involves the following packages:

HLTrigger/Muon

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@abbiendi, @trocino, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

@@ -54,6 +55,7 @@ HLTMuonTrkFilter::fillDescriptions(edm::ConfigurationDescriptions& descriptions)
desc.add<unsigned int>("requiredTypeMask",0);
desc.add<unsigned int>("trkMuonId",0);
desc.add<double>("minPt",24);
desc.add<double>("maxAbsEta",1e99);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we set the default maximum value to 2.5 ?
It should be high enough to reproduce the old behaviour, and it is what is used in the corresponding filter for L3 muons.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once it is added and parsed, we can set it in ConfDB to any value we like.

davidlange6 added a commit that referenced this pull request Oct 14, 2014
…erIn72X

backport PR#5767 in CMSSW_7_2_X (Addition of a parameter in HLTMuonTrkFilter to cut on absEta)
@davidlange6 davidlange6 merged commit 921eb88 into cms-sw:CMSSW_7_2_X Oct 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants