Move FWEveDigitSetScalableMarker delcaration in header file. Related to #332 #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
+1 |
|
ciao @alja I'll use this pull request as a test, pardon extra emails. |
|
+1 |
|
-1 |
|
+1 |
|
hold |
|
+1 |
|
@nclopezo please test. |
|
Hi, Anyway, I took these changes on top of CMSSW_7_0_X_2013-08-21-0200, I ran the unit tests and RelVals, all tests passed. You can see the logs here: |
ktf
added a commit
that referenced
this pull request
Aug 21, 2013
Move FWEveDigitSetScalableMarker delcaration in header file. Related to #332
nclopezo
pushed a commit
to nclopezo/cmssw
that referenced
this pull request
Apr 30, 2014
Use root 5.34.17 in stable branch
gpetruc
pushed a commit
to gpetruc/cmssw
that referenced
this pull request
Jan 4, 2016
Include the possibility to use the conversion-safe electron veto in the PhotonAnalyzer
cmsbuild
pushed a commit
that referenced
this pull request
Nov 27, 2020
Move SiPixelFedCablingMapGPU code from RecoLocalTracker/SiPixelClusterizer/ to - CondFormats/SiPixelObjects/ - CalibTracker/SiPixelESProducers/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pull request #332 were problems with dictionary since Fireworks/Core/src/FWEveDigitSetScalableMarker.cc file was included in classes.h.
I have split the code into source and header so that classes.h include only header files. As I understand a workaround for problem in #332 has already been made, but not included in the official cmssw repository.