New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry and configuration of Magnetic Field from DB #5785
Conversation
…llow XMLGeometryBuilder to optionally use the new MF geometry record
A new Pull Request was created by @namapane (Nicola Amapane) for CMSSW_7_3_X. Geometry and configuration of Magnetic Field from DB It involves the following packages: CondCore/Utilities The following packages do not have a category, yet: CondFormats/MFObjects @apfeiffer1, @nclopezo, @cerminar, @cmsbuild, @diguida, @rcastello, @StoyanStoynev, @slava77, @ggovi can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
-1 >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_3_X_2014-10-13-0200/src/SimMuon/DTDigitizer/test/testDriftTimeParam.cpp Entering library rule at SimMuon/CSCDigitizer Entering library rule at MagneticField/ParametrizedEngine >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_3_X_2014-10-13-0200/src/MagneticField/ParametrizedEngine/test/TKBfield_t.cpp In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_3_X_2014-10-13-0200/src/MagneticField/ParametrizedEngine/test/TKBfield_t.cpp:1:0: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_3_X_2014-10-13-0200/poison/MagneticField/ParametrizedEngine/plugins/TkBfield.cc:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. ^ /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_3_X_2014-10-13-0200/src/MagneticField/ParametrizedEngine/test/TKBfield_t.cpp: In function 'int main()': /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_3_X_2014-10-13-0200/src/MagneticField/ParametrizedEngine/test/TKBfield_t.cpp:7:3: error: 'magfieldparam' has not been declared magfieldparam::TkBfield field; you can see the results of the tests here: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
Geometry and configuration of Magnetic Field from DB
@@ -31,7 +31,6 @@ | |||
#include "CondFormats/DTObjects/interface/DTLVStatus.h" | |||
#include "CondFormats/DTObjects/interface/DTMtime.h" | |||
#include "CondFormats/DTObjects/interface/DTReadOutMapping.h" | |||
#include "CondFormats/DTObjects/interface/DTRecoUncertainties.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@namapane
I realise this just now: why have you removed DTRecoUncertainties
from the list of known Condition classes?
Just a leftover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@namapane
Ah, you are right: DTRecoUncertainties
was included twice, see line 37.
Sorry for the noise
Infrastructure to take the MF geometry and configuration from DB instead than from python cfg.
Changes include:
This PR introduces no change in standard configurations (regression tested). Plan to switch to the new mechanism in a future PR, once the DB is populated with the new payloads.
Relevant Discussion:
https://indico.cern.ch/event/328166/session/1/contribution/24