Changing exceptions to LogErrors where appropriate

[rappoccio]

Masking problem reported here :
https://hypernews.cern.ch/HyperNews/CMS/get/relval/3177.html
The new code will no longer throw Exception, but instead print to the LogError stream.

[cmsbuild]

A new Pull Request was created by @rappoccio for CMSSW_7_2_X.

Changing exceptions to LogErrors where appropriate

It involves the following packages:

CondFormats/JetMETObjects

@apfeiffer1, @nclopezo, @monttj, @cmsbuild, @ggovi, @vadler can you please review it and eventually sign? Thanks.
@nhanvtran, @TaiSakuma, @mmarionncern, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[apfeiffer1]

hmm ... did not read the full file, but should this logError not be inside an "else" or something ?

[rappoccio]

Good catch. This is supposed to have an else. One moment.

[cmsbuild]

+1
Tested at: d86f5ed
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5803/55/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5803/55/summary.html

[vadler]

@ktf : Compilation currently fails with

c++: internal compiler error: Killed (program cc1plus)

even without the code changes introduced here.
I have tried CMSSW_7_2_X_2014-10-12-0200 and CMSSW_7_2_X_2014-10-09-1400.
73X is fine, thought.

[davidlt]

@vadler what compiler? If 4.8, have you tried 4.9? I see this marked as "tests-approved". Could you provide full recipe for producing ICE (internal compiler error)?

[vadler]

On LXPLUS:

setenv SCRAM_ARCH slc6_amd64_gcc481
cmsrel CMSSW_7_2_X_2014-10-12-0200
cd CMSSW_7_2_X_2014-10-12-0200/src
cmsenv
git cms-addpkg CondFormats/JetMETObjects
git checkout -b test-5803
git cms-merge-topic 5803
git checkout from-CMSSW_7_2_X_2014-10-12-0200
scram b -j20

I'm trying 491 now....

[vadler]

Same thing with 491 :(
It seems to bee release cycle related, since 73X compiles fine.

[davidlt]

@vadler all worked fine on cmsdev04. Could you point to exact lxplus machine?

[vadler]

It indeed seems to be related to the machine (lxplus0115) and the -j20 option. It also worked fine for me without that or on a different machine.

[davidlt]

Ah, I just now looked again at the message Killed (program cc1plus). It's probably OOM (out-of-memory) killer. You might be pushing machine too hard on memory side. It's something like 1GB per GCC instance.

[davidlange6]

@vadler - is this one ready for you? (and the same for 70x)

[vadler]

+1
Tested with customized WF 4.73 (reproducing the same error as in https://hypernews.cern.ch/HyperNews/CMS/get/relval/3177.html at CERN) in CMSSW_7_2_X_2014-10-12-0200.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?