Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MiniAOD for InputGenJetsParticleSelector: Forward port from 7_2_X to 7_3_X #5805

Merged
merged 6 commits into from Oct 17, 2014
Merged

MiniAOD for InputGenJetsParticleSelector: Forward port from 7_2_X to 7_3_X #5805

merged 6 commits into from Oct 17, 2014

Conversation

ferencek
Copy link
Contributor

Forward port of #5731

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Oct 14, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_3_X.

MiniAOD for InputGenJetsParticleSelector: Forward port from 7_2_X to 7_3_X

It involves the following packages:

RecoJets/JetProducers
Validation/RecoTau

@nclopezo, @StoyanStoynev, @danduggan, @rovere, @cmsbuild, @deguio, @slava77, @ojeda can you please review it and eventually sign? Thanks.
@yslai, @TaiSakuma, @nhanvtran, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

+1
Tested at: 15f0eeb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5805/53/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5805/53/summary.html

@vadler
Copy link

vadler commented Oct 16, 2014

@StoyanStoynev : Looks identical to #5731 .

@deguio
Copy link
Contributor

deguio commented Oct 16, 2014

+1

@StoyanStoynev
Copy link
Contributor

+1
Tested 15f0eeb on top of CMSSW_7_3_X_2014-10-15-1400 .
This PR is identical to #5731 but I had to retest as jenkins show some limited number of differences (DQM, wf 4.22 and 4.53 for example). I ran locally short matrix tests and see no differences. There are current issues with jenkins (sometimes) that we do not understand.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 17, 2014
@nclopezo
Merge pull request #5805 from ferencek/MiniAODForInputGenJetsParticle…
5e25674 
…Selector_from-CMSSW_7_3_X_2014-10-13-1400

MiniAOD for InputGenJetsParticleSelector: Forward port from 7_2_X to 7_3_X
@nclopezo nclopezo merged commit 5e25674 into cms-sw:CMSSW_7_3_X Oct 17, 2014
@cmsbuild
Copy link
Contributor

+1
Tested at: 15f0eeb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5805/131/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5805/131/summary.html

nclopezo added a commit to nclopezo/cmssw that referenced this pull request Oct 21, 2014
@nclopezo
Revert "Merge pull request cms-sw#5805 from ferencek/MiniAODForInputG…
869d97a 
…enJetsParticleSelector_from-CMSSW_7_3_X_2014-10-13-1400"

This reverts commit 5e25674, reversing
changes made to c7dbe66.
@ferencek ferencek deleted the MiniAODForInputGenJetsParticleSelector_from-CMSSW_7_3_X_2014-10-13-1400 branch October 27, 2014 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed reconstruction-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ferencek @cmsbuild @StoyanStoynev @vadler @deguio @nclopezo